Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning about machineid #21

Closed
wants to merge 1 commit into from

Conversation

mathnogueira
Copy link
Contributor

We had problems when running the keygen example on Docker and after some debugging we found out the machineid file was missing and it was making the license verification to fail.

As most applications will run on Docker, a warning about this would be useful.

We had problems when running the keygen example on Docker and after some debugging we found out the `machineid` file was missing and it was making the license verification to fail. 

As most applications will run on Docker, a warning about this would be useful.
@ezekg
Copy link
Member

ezekg commented Jul 19, 2024

I don't think adding this warning is necessary, simply because it's not an official dependency of this SDK. Instead, I'd rather find and link to a fork of the machineid package that supports Docker, because it looks like that package is unmaintained. See denisbrodbeck/machineid#5.

For example, we maintain a Python library that is based on that Go package and the community added Docker support using the container ID: https://github.com/keygen-sh/py-machineid.

Perhaps we can fork and do the same for that unmaintained Go package. Feel free to make a PR: https://github.com/keygen-sh/machineid

@ezekg ezekg closed this Jul 19, 2024
@ezekg
Copy link
Member

ezekg commented Jul 19, 2024

Alternatively, we could update the example to use https://github.com/panta/machineid, which is a fork that loosely supports Docker by writing a UUID to one of the ID files if no ID exists.

@mathnogueira mathnogueira deleted the patch-1 branch August 7, 2024 17:39
@mathnogueira
Copy link
Contributor Author

I decided to open a PR to your fork instead. Panta's fork seems to be unmaintained as well because there's a PR there with an important fix that is open for more than an year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants