feat(developer): verify that packages do not contain themselves in kmc-package #13157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
requested review from
darcywong00,
SabineSIL,
markcsinclair and
srl295
as code owners
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
approved these changes
Feb 7, 2025
| return true; | ||
| } | ||
|
|
||
| private doesContentFileEqualOutputFilename(file: KmpJsonFile.KmpJsonFileContentFile, outputFilename: string): boolean { |
There was a problem hiding this comment.
For consistency with the other methods, maybe rename to
Suggested change
| private doesContentFileEqualOutputFilename(file: KmpJsonFile.KmpJsonFileContentFile, outputFilename: string): boolean { | |
| private checkIfContentFileEqualsOutputFilename(file: KmpJsonFile.KmpJsonFileContentFile, outputFilename: string): boolean { |
There was a problem hiding this comment.
I actually didn't use checkIf deliberately, because checkIf... also reports a message, whereas does... just checks without reporting. Probably would be better to refactor checkIf... functions to just does... in the future, but super lowpri.
developer/src/kmc-package/test/fixtures/invalid/error_package_must_not_contain_itself.kps
Outdated
Show resolved
Hide resolved
Co-authored-by: Darcy Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13109
@keymanapp-test-bot skip