Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): link welcome.htm in package for new projects; use v17 project format for new models #13161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Feb 7, 2025

  • Links welcome.htm in the package details for all project types
  • Uses v17 project file format for new lexical model projects
  • Nit: changes shortcut key for 'supported languages' from 'l' to 's' to fix conflict with 'full copyright'.

Fixes: #13135

@keymanapp-test-bot skip

…7 project format for new models

* Links welcome.htm in the package details for all project types
* Uses v17 project file format for new lexical model projects
* Nit: changes shortcut key for 'supported languages' from 'l' to 's'
  to fix conflict with 'full copyright'.

Fixes: #13135
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 7, 2025

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@darcywong00
Copy link
Contributor

Tweaking PR title for verb first 😄

@darcywong00 darcywong00 changed the title fix(developer): for new projects, link welcome.htm in package; use v17 project format for new models fix(developer): link welcome.htm in package for new projects; use v17 project format for new models Feb 7, 2025
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

bug(developer): New Project creates old format model projects and has missing welcome.htm link
2 participants