fix(windows): check the params status flag equals ucrsUpdateReady before attempting to download the keyman setup file #13154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case when a Keyboard was available for update but the keyman version wasn't the state machine correctly didn't try to install it. However the back ground download loop would try to download and empty Params.InstallURL. This commit now checks the Params.Status. This commit also removes the dead code for TDownloadUpdateParams record type. This code is left over from a progress ui callback. It was initially left for when UI callback maybe added back in. However, it is currently confusing deadcode so has been removed. Fixes: #13153
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions Test Artifacts |
keymanapp-test-bot
bot
added
has-user-test
user-test-required
…-keyman-file-status
# Keyman Conventional Commit suggestions:
#
# - Link to a Sentry issue with git trailer:
# Fixes: _MODULE_-_ID_
# - Give credit to co-authors:
# Co-authored-by: _Name_ <_email_>
# - Use imperative, present tense ('attach' not 'attaches', 'attached' etc)
# - Don't include a period at the end of the title
# - Always include a blank line before trailers
# - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
rc-swag
changed the title
rc-swag
changed the title
rc-swag
changed the title
Test ResultsI tested this issue with the attached Keyman"18.0.187-alpha-test-13154" build(07/02/2025) on Windows 10. Here I am sharing my observation.
|
keymanapp-test-bot
bot
removed
the
user-test-required
ermshiperete
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case when a Keyboard was available for update but the keyman version wasn't the state machine correctly didn't try to install it. However the back ground download loop would try to download and empty Params.InstallURL. This commit now checks the Params.Status. This commit also removes the dead code for TDownloadUpdateParams record type. This code is left over from a progress ui callback. It was initially left for when UI callback maybe added back in. However, it is currently confusing deadcode so has been removed.
Fixes: #13153
Fixes: KEYMAN-WINDOWS-4W5
User Testing
TEST_IDLE_KMSHELL_UPDATEDS_KBDS_ONLY
To Test this PR we need it so there are no newer updates available. If there are let me know and
I will merge in the lastest master again.
update statefound at (Computer\HKEY_CURRENT_USER\SOFTWARE\Keyman\Keyman Engine).usIdlecd "c:\Program Files (x86)\Keyman\Keyman Desktop"kmshell.exe -bucupdate statehas advanced tousUpdateAvailablethenusDownloadingand finallyusWaitngRestart. Press F5 to refresh the view.