-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: IP Blacklisting on workspaces #127
Comments
/attempt for fosshack |
Assigned the issue to @Z-xus! |
Hey I am Kartik Deshmukh. I am one of the participants in the FOSS Hack. We want to contribute to this issue and I feel confident my contribution will help! |
@MelloB1989 hello! Please make sure that no one's assigned to the issue before you try to get assigned since that's against the guidelines for this hackathon. |
Hi, I have created the guard and schema, I wanted to know which controller methods require the guard and also do you need another controller method to update the blacklistedIps[] or just a service method? |
We would need a separate guard that will work on every endpoint related to workspaces. And yes, we want to allow another endpoint that would allow workspace admins to update the blacklisted IP addresses. Ideally, this should be in workspace controller. |
@Z-xus you still on this? |
Sorry, I loved working here but I can't spare the time to do so anymore.. |
Ah man, that's sad. It's okay. We would be glad to have you back dropping more PRs when you can! Appreciate all the help that you have been so far. |
Description
Add a feature that will enforce security of the workspaces by blocking users from accessing it if their IP addresses are in the blacklist. We would support both IPv4 and IPv6 address blacklisting. Workspace administrators would be able to update the blacklist of the workspaces.
Solution
The text was updated successfully, but these errors were encountered: