Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATFORM: Implement Google, GitLab and GitHub #307

Open
kriptonian1 opened this issue Jul 3, 2024 · 16 comments
Open

PLATFORM: Implement Google, GitLab and GitHub #307

kriptonian1 opened this issue Jul 3, 2024 · 16 comments
Labels
difficulty: 2 hacktoberfest Hacktoberfest is on! priority: medium scope: platform Everything related to the keyshade platform package type: feature Release drafter tag for tagging PRs related to adding new features

Comments

@kriptonian1
Copy link
Contributor

kriptonian1 commented Jul 3, 2024

Description

Implement Google, GitLab, and GitHub to the /auth so that user can use OAuth to log in to our application.

Scope of Work

  1. You need to implement Google, GitLab, and GitHub end points to the platform's /auth.
  2. After the authentication is successful, it will automatically be redirected to the /auth/account-details page from the backend.

URL endpoints with Postman Links

Figma link

  • Google Auth flow link
  • GitHub Auth flow link
  • GitLab Auth flow link
@kriptonian1 kriptonian1 added type: feature Release drafter tag for tagging PRs related to adding new features scope: platform Everything related to the keyshade platform package priority: medium difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 labels Jul 3, 2024
@harshdeshmukh21
Copy link

I would like to work on this issue. I have worked with OAuth before and I feel I can do this task. I have registered my team via Foss Hack.

@rajdip-b
Copy link
Member

Hey @harshdeshmukh21! The implementation of OAuth is done in the backend. We would just need you to tie up the logic with the frontend. But yes, go ahead!

@harshdeshmukh21
Copy link

I am able to run the api and web app locally. Since my issue is platform related, how can I run platform locally? @rajdip-b

@rajdip-b
Copy link
Member

It is exactly similar to how you run web. We do need to work on the docs :)

@harshdeshmukh21
Copy link

Can I get the client ids and secrets for Google, GitHub and GitLab or do I have to create clients for testing?

@harshdeshmukh21
Copy link

harshdeshmukh21 commented Jul 23, 2024

Also is there any message after running all the apis sucessfully? Because I feel there is some kind of error and I am not able to access all the routes. Only the /auth route is accessible.

@rajdip-b
Copy link
Member

Can I get the client ids and secrets for Google, GitHub and GitLab or do I have to create clients for testing?

We would have loved to, but then we are also using it in our prod :(

Also is there any message after running all the apis sucessfully? Because I feel there is some kind of error and I am not able to access all the routes. Only the /auth route is accessible.

Most of the errors are originated from env stuff. You can give this a read: https://docs.keyshade.xyz. Additionally, you can post screenshots in here.

@kriptonian1
Copy link
Contributor Author

Hey @harshdeshmukh21, To run everything locally, you need to go through the docs and st the thing up, and to run the web you can follow this comment #244 (comment), here it is mentioned how to run the platform.

@harshdeshmukh21
Copy link

Can I get the SMTP credentials for running the API?

@rajdip-b
Copy link
Member

Unfortunately, you would have to get your own keys!

@harshdeshmukh21
Copy link

Even after setting up SMTP with google, I am not able to run the api completely. Apparently, it is stuck on this.
Screenshot 2024-07-27 at 5 25 33 PM

@keyshade-xyz keyshade-xyz deleted a comment from rajdip-b Jul 28, 2024
@kriptonian1
Copy link
Contributor Author

@harshdeshmukh21 the email must be in the format of FROM_EMAIL="harsh <[email protected]>"

@kriptonian1
Copy link
Contributor Author

@harshdeshmukh21 are you still working on this issue?

@harshdeshmukh21
Copy link

@harshdeshmukh21 are you still working on this issue?

Nope. I tried a lot but wasn't able to do it. Thanks for assigning me the issue. You may reassaign it to someone else.

@kriptonian1 kriptonian1 added hacktoberfest Hacktoberfest is on! and removed foss hack Clustering all the curated issues for Foss Hack 2024 labels Oct 4, 2024
@dev-palwar
Copy link

Hey @kriptonian1 Would it be okay if I take this on? I've done it before

@rajdip-b
Copy link
Member

Yeah you can go ahead @dev-palwar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 2 hacktoberfest Hacktoberfest is on! priority: medium scope: platform Everything related to the keyshade platform package type: feature Release drafter tag for tagging PRs related to adding new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants