-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate pg-boss for job scheduling #478
feat: Integrate pg-boss for job scheduling #478
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@rajdip-b Argument of type V is failing, since it's unknown what type of data is being passed. |
@rajdip-b https://timgit.github.io/pg-boss/#/./api/constructor?id=newconnectionstring should be a valid constructor |
@rajdip-b A bit help here on why tests are failing. I followed |
499dc08
to
a5a371b
Compare
a5a371b
to
6ee16bc
Compare
Yes, you would need that. What im saying is, you can have that instance of the class in a nestjs provider. you can check how redis is implemented in a similar manner. and you can also look at how the tests work for that. |
Hey dude, i'm closing this PR since this seems really obsolete as of now. I'll also be closing the issue. Thanks for grinding the time in here! |
User description
Description
This PR adds a integrates
pg-boss
for job scheduling. This allows us to run jobs in the background as cron jobs or jobs that might take up significant resources.Fixes #138
Dependencies
Installed packages:
pg-boss
Future Improvements
N/A
Mentions
@rajdip-b
Screenshots of relevant screens
N/A
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Enhancement
Description
pg-boss
for job scheduling by adding a newJobHandler
class.CommonModule
to includeJobHandler
in providers and exports.pg-boss
to the project dependencies inpackage.json
.pnpm-lock.yaml
to reflect the new dependencies.Changes walkthrough 📝
common.module.ts
Add JobHandler to CommonModule providers and exports
apps/api/src/common/common.module.ts
JobHandler
to the providers and exports arrays.job.handler.ts
Implement JobHandler class for job scheduling
apps/api/src/common/job.handler.ts
JobHandler
class for managing jobs withpg-boss
.package.json
Add pg-boss dependency for job scheduling
apps/api/package.json
pg-boss
as a new dependency.reflect-metadata
in devDependencies.pnpm-lock.yaml
Update pnpm-lock.yaml with pg-boss dependencies
pnpm-lock.yaml
pg-boss
and its dependencies.