Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-CLIENT: Unable to infer type when using the package in client apps #512

Closed
rajdip-b opened this issue Oct 28, 2024 · 6 comments
Closed
Assignees
Labels

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Oct 28, 2024

Describe the bug

The API Client package is used by other clients (in the apps folder) to call the API. Currently, we are facing the issue where the client apps are not able to infer the types, even though the API Client package has a well-defined type. We would like someone to investigate the issue.

image

Use this link for reference: https://stackoverflow.com/questions/56018167/typescript-does-not-copy-d-ts-files-to-build

@rajdip-b rajdip-b changed the title API-CLIENT API-CLIENT: Unable to infer type when using the package in client apps Oct 28, 2024
@Avik-creator
Copy link

Can I pick this up? @rajdip-b

@rajdip-b
Copy link
Member Author

Hey bruh! Sure go ahead.

@muntaxir4
Copy link
Contributor

muntaxir4 commented Nov 16, 2024

The error for authController was fixed when migrated to .ts https://github.com/keyshade-xyz/keyshade/blob/46eb5c5aeee76f60015e65174e9cb9ea97f5e771/packages/api-client/src/types/auth.types.ts#L1C1-L4C38.

Once, Issue #519 is resolved by moving the types to just .ts, this will be fixed.

@Avik-creator
Copy link

I guess you then solved it. Today I was going to sit for the error

@rajdip-b
Copy link
Member Author

Yeah, the timeline got messed up a bit. We didn't realize these were dependent issues!

@rajdip-b
Copy link
Member Author

rajdip-b commented Dec 4, 2024

This is fixed! Closing the issue.

@rajdip-b rajdip-b closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants