Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add support for sentry #529

Open
rajdip-b opened this issue Nov 11, 2024 · 2 comments
Open

CLI: Add support for sentry #529

rajdip-b opened this issue Nov 11, 2024 · 2 comments
Labels
difficulty: 3 help wanted Extra attention is needed pending-dependency Stuck due to a required dependency priority: high scope: cli Everything related to the CLI type: enhancement New feature or request

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Nov 11, 2024

Description

We would like the CLI to send errors to Sentry if metrics_enabled (refer to #528) is enabled. Sentry should be notified in the following events:

  • An internal error occurs in any of the components of the CLI
  • A 500 is returned from the API

Solution

  • You would need to send the error to sentry with the environment set as CLI.
  • Add a Logger.report function that will be used to first call Logger.error and then send the data to sentry. We should not be printing too much using Logger.error in this case.

Requires #528

@rajdip-b rajdip-b added type: enhancement New feature or request help wanted Extra attention is needed pending-dependency Stuck due to a required dependency priority: high difficulty: 3 scope: cli Everything related to the CLI labels Nov 11, 2024
@adityaRajGit
Copy link

Can I try?

@rajdip-b
Copy link
Member Author

Sure!, but it depends on the #528 so we need that before you an attempt this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 3 help wanted Extra attention is needed pending-dependency Stuck due to a required dependency priority: high scope: cli Everything related to the CLI type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants