Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve loading SVG blocking input field interaction #571

Conversation

Allan2000-Git
Copy link
Contributor

@Allan2000-Git Allan2000-Git commented Dec 1, 2024

User description

Description

Fixed by making the height of the SVG to auto and also disabled the interaction with the input field when isLoading is true

Fixes #567

Dependencies

N/A

Future Improvements

N/A

Mentions

@rajdip-b

Screenshots of relevant screens

Screenshot (93)

Developer's checklist

  • My PR follows the style guidelines of this project
  • [ X I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

PR Type

Bug fix


Description

  • Fixed an issue where the loading SVG was blocking interaction with the input field by setting its height to auto.
  • Corrected a typo in the text content on the authentication page.

Changes walkthrough 📝

Relevant files
Bug fix
page.tsx
Adjust SVG height and fix typo in AuthPage                             

apps/platform/src/app/auth/page.tsx

  • Adjusted the LoadingSVG component to have a height of auto to prevent
    it from blocking the input field.
  • Fixed a typo in the text content.
  • +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    567 - Fully compliant

    Compliant requirements:

    • Loading SVG height set to 'auto' to prevent blocking input field
    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    UI Validation
    Verify that the loading SVG no longer blocks input field interaction and is properly positioned with auto height

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Prevent layout shifts during loading state transitions by using fixed-width containers

    Add a fixed width to the LoadingSVG container to prevent layout shifts when the
    loading state changes. This ensures consistent button width during state
    transitions.

    apps/platform/src/app/auth/page.tsx [100]

    -{isLoading ? <LoadingSVG className="w-10 h-auto" /> : 'Get Started'}
    +{isLoading ? <div className="w-20 flex justify-center"><LoadingSVG className="w-10 h-auto" /></div> : 'Get Started'}
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion addresses a potential UI issue where the button width might change during loading state transitions, which could cause jarring layout shifts. Adding a fixed-width container improves the user experience by maintaining visual stability.

    7

    💡 Need additional feedback ? start a PR chat

    @rajdip-b
    Copy link
    Member

    rajdip-b commented Dec 1, 2024

    @poswalsameer is this good to merge?

    @poswalsameer
    Copy link
    Contributor

    @poswalsameer is this good to merge?

    Yes, you can go for it.

    @rajdip-b
    Copy link
    Member

    rajdip-b commented Dec 2, 2024

    @Allan2000-Git can you resolve the conflicts? We will merge after that.

    @rajdip-b rajdip-b merged commit 30f4f65 into keyshade-xyz:develop Dec 2, 2024
    4 checks passed
    rajdip-b pushed a commit that referenced this pull request Dec 3, 2024
    ## [2.8.0](v2.7.0...v2.8.0) (2024-12-03)
    
    ### 🚀 Features
    
    * **api:** Add workspace removal notification email template ([#476](#476)) ([40b754f](40b754f))
    * **cli:** Store `metrics_enabled` key in profile config ([#536](#536)) ([9283b22](9283b22))
    * **package, api, cli:** Add api-key schemas and types; Fix schema inconsistencies; Minor fix for CLI build errors  ([#557](#557)) ([126d024](126d024))
    * **platform:** Added screen for CREATE NEW PROJECT ([#540](#540)) ([b644633](b644633))
    * **platform:** Updated the empty state of dashboard ([#522](#522)) ([28739d9](28739d9))
    * **schema, api-client:** Migrate auth types to @keyshade/schema ([#532](#532)) ([d880098](d880098))
    * **schema, api-client:** Migrate event schemas and types to @keyshade/schema ([#546](#546)) ([a3267de](a3267de))
    * **schema, api-client:** Migrate integration schemas and types to @keyshade/schema ([#547](#547)) ([08868c3](08868c3))
    * **schema, api-client:** Migrate project schemas and environment schemas along with their types to @keyshade/schema ([#538](#538)) ([c468af0](c468af0))
    * **schema, api-client:** Migrate [secure] types and schemas to @keyshade/schema ([#539](#539)) ([bc3100b](bc3100b))
    * **schema, api-client:** Migrate user types and schemas to @keyshade/schema ([#535](#535)) ([c24695e](c24695e))
    * **schema, api-client:** Migrate variable schemas and types to @keyshade/schema ([#545](#545)) ([0ee8f9a](0ee8f9a))
    * **schema, api-client:** Migrate workspace-membership schemas and types to @keyshade/schema ([#569](#569)) ([4398969](4398969))
    * **schema, api-client:** Migrate workspace-role schemas and types to @keyshade/schema ([#568](#568)) ([9efbf2d](9efbf2d))
    * **schema:** Add User type inference from UserSchema ([#574](#574)) ([84c1db5](84c1db5))
    
    ### 🐛 Bug Fixes
    
    * **api:** Incorrect oauth redirect url ([58d96e5](58d96e5))
    * **platform:** Resolve loading SVG blocking input field interaction ([#571](#571)) ([30f4f65](30f4f65))
    
    ### 📚 Documentation
    
    * Add pictures to Bruno setup ([#541](#541)) ([210c0fd](210c0fd))
    * Migrate to Bruno ([#525](#525)) ([1793d92](1793d92))
    
    ### 🔧 Miscellaneous Chores
    
    * **ci:** Add script to validate schema package ([59e4280](59e4280))
    * Fixed codecov client version ([a998ae4](a998ae4))
    * **package:** Fixed tests and did housekeeping ([#544](#544)) ([40008e3](40008e3))
    * Update test coverage settings ([5b27e32](5b27e32))
    * Update Turbo to 2.3.1 ([#564](#564)) ([3a63823](3a63823))
    * **web:** Update dockerfile ([10d9cc5](10d9cc5))
    
    ### 🔨 Code Refactoring
    
    * **api-client, schema:** Add workspace's schemas and types in @keyshade/schema ([#520](#520)) ([7c8ee5d](7c8ee5d))
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Bug: Loading SVG Blocks Input Field Interaction
    3 participants