-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve loading SVG blocking input field interaction #571
fix: resolve loading SVG blocking input field interaction #571
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@poswalsameer is this good to merge? |
Yes, you can go for it. |
@Allan2000-Git can you resolve the conflicts? We will merge after that. |
…thub.com/Allan2000-Git/keyshade into fix/blocking-svg-input-field-interaction
## [2.8.0](v2.7.0...v2.8.0) (2024-12-03) ### 🚀 Features * **api:** Add workspace removal notification email template ([#476](#476)) ([40b754f](40b754f)) * **cli:** Store `metrics_enabled` key in profile config ([#536](#536)) ([9283b22](9283b22)) * **package, api, cli:** Add api-key schemas and types; Fix schema inconsistencies; Minor fix for CLI build errors ([#557](#557)) ([126d024](126d024)) * **platform:** Added screen for CREATE NEW PROJECT ([#540](#540)) ([b644633](b644633)) * **platform:** Updated the empty state of dashboard ([#522](#522)) ([28739d9](28739d9)) * **schema, api-client:** Migrate auth types to @keyshade/schema ([#532](#532)) ([d880098](d880098)) * **schema, api-client:** Migrate event schemas and types to @keyshade/schema ([#546](#546)) ([a3267de](a3267de)) * **schema, api-client:** Migrate integration schemas and types to @keyshade/schema ([#547](#547)) ([08868c3](08868c3)) * **schema, api-client:** Migrate project schemas and environment schemas along with their types to @keyshade/schema ([#538](#538)) ([c468af0](c468af0)) * **schema, api-client:** Migrate [secure] types and schemas to @keyshade/schema ([#539](#539)) ([bc3100b](bc3100b)) * **schema, api-client:** Migrate user types and schemas to @keyshade/schema ([#535](#535)) ([c24695e](c24695e)) * **schema, api-client:** Migrate variable schemas and types to @keyshade/schema ([#545](#545)) ([0ee8f9a](0ee8f9a)) * **schema, api-client:** Migrate workspace-membership schemas and types to @keyshade/schema ([#569](#569)) ([4398969](4398969)) * **schema, api-client:** Migrate workspace-role schemas and types to @keyshade/schema ([#568](#568)) ([9efbf2d](9efbf2d)) * **schema:** Add User type inference from UserSchema ([#574](#574)) ([84c1db5](84c1db5)) ### 🐛 Bug Fixes * **api:** Incorrect oauth redirect url ([58d96e5](58d96e5)) * **platform:** Resolve loading SVG blocking input field interaction ([#571](#571)) ([30f4f65](30f4f65)) ### 📚 Documentation * Add pictures to Bruno setup ([#541](#541)) ([210c0fd](210c0fd)) * Migrate to Bruno ([#525](#525)) ([1793d92](1793d92)) ### 🔧 Miscellaneous Chores * **ci:** Add script to validate schema package ([59e4280](59e4280)) * Fixed codecov client version ([a998ae4](a998ae4)) * **package:** Fixed tests and did housekeeping ([#544](#544)) ([40008e3](40008e3)) * Update test coverage settings ([5b27e32](5b27e32)) * Update Turbo to 2.3.1 ([#564](#564)) ([3a63823](3a63823)) * **web:** Update dockerfile ([10d9cc5](10d9cc5)) ### 🔨 Code Refactoring * **api-client, schema:** Add workspace's schemas and types in @keyshade/schema ([#520](#520)) ([7c8ee5d](7c8ee5d))
User description
Description
Fixed by making the height of the SVG to
auto
and also disabled the interaction with the input field whenisLoading
is trueFixes #567
Dependencies
N/A
Future Improvements
N/A
Mentions
@rajdip-b
Screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update
PR Type
Bug fix
Description
auto
.Changes walkthrough 📝
page.tsx
Adjust SVG height and fix typo in AuthPage
apps/platform/src/app/auth/page.tsx
LoadingSVG
component to have a height ofauto
to preventit from blocking the input field.