Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Test failure while non-member tries to access a global project #575

Closed
rajdip-b opened this issue Dec 3, 2024 · 2 comments · Fixed by #580
Closed

BUG: Test failure while non-member tries to access a global project #575

rajdip-b opened this issue Dec 3, 2024 · 2 comments · Fixed by #580
Assignees
@muntaxir4
Labels
difficulty: 3 good first issue Good for newcomers help wanted Extra attention is needed priority: high scope: api Everything related to the API type: bug Something isn't working

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Dec 3, 2024

Describe the bug

Projects with access level set to GLOBAL should be accessible by anyone in the world. Right now, the test that covers this scenario is failing.

To Reproduce
Steps to reproduce the behavior:

  1. Go to project.e2e.spec.ts in apps/api/src/project.
  2. Uncomment lines 870-886
  3. Run pnpm e2e:api
  4. Encounter the error.

Expected behavior
The tests should pass, and the scenario should be evaluated.

Screenshots

  • Commented out code:
    image
  • Error while running tests:
    image
@rajdip-b rajdip-b added type: bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed scope: api Everything related to the API priority: high difficulty: 3 labels Dec 3, 2024
@rajdip-b rajdip-b moved this to Todo in keyshade-api Dec 3, 2024
@muntaxir4
Copy link
Contributor

muntaxir4 commented Dec 5, 2024 •
edited
Loading

Are the environments, secrets and variables accessible to any user if the project is global and the user is not a member of workspace?

@rajdip-b
Copy link
Member Author

rajdip-b commented Dec 6, 2024

Yes

@muntaxir4 muntaxir4 mentioned this issue Dec 6, 2024
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in keyshade-api Dec 7, 2024
@rajdip-b rajdip-b moved this from Done to Queued for release in keyshade-api Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muntaxir4 muntaxir4

Labels
difficulty: 3 good first issue Good for newcomers help wanted Extra attention is needed priority: high scope: api Everything related to the API type: bug Something isn't working
Projects
keyshade-api
Status: Queued for release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api): Enable global project access muntaxir4/keyshade
2 participants
@muntaxir4 @rajdip-b