API: Get all workspaces of user returns every workspace as default

[muntaxir4]

Describe the bug
All returned workspaces from /workspace contains isDefault: true, whereas only one workspace should be a default one. This happens when a user becomes a member of host's default workpsace.

Endpoints Affected

• /workspace
• /workspace/:workspaceSlug

To Reproduce
Steps to reproduce the behavior:

1. User1 invites User2 to their default workspace.
2. User2 requests to view all of their accessible workspaces from /workpsace. Each of the workspace has isDefault set to true.

Expected behavior
A single Default workspace of User2 should have isDefault:true.

[zaheer-Khan3260]

Hey @rajdip-b, Please assign it to me.

[muntaxir4]

Hey @rajdip-b, Please assign it to me.

You can take up this issue using /attempt

[csehatt741]

@zaheer-Khan3260, @muntaxir4, any progress here?

I can take a look at this issue, just assign it to me, please.

[rajdip-b]

Sure you ca go for it.

[csehatt741]

I`ve managed to reproduce this issue locally.

Do you mean only the default workspace of User2 should have isDefault: true, while the default workspace of User1 should have isDefault: false?

[rajdip-b]

Yes. Every user has a default workspace. If you get invited to someone else's default workspace, you still own a default workspace of your own.

The issue is, right now we are just fetching every workspace without processing the ownerId field.

So, what we want is, before sending out the workspace, we want to do a pre-processing that checks the following clause:

workspace.isDefault = workspace.isDefault && workspace.ownerId == user.id

[rajdip-b]

🎉 This issue has been resolved in version 2.10.0-stage.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[rajdip-b]

🎉 This issue has been resolved in version 2.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀