-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflows): Add internal package dependencies to existing workflows #592
feat(workflows): Add internal package dependencies to existing workflows #592
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch dude <3
User description
Description
We encountered unexpected issues when internal dependencies in the apps were changed. Updating the existing workflows will help catch such errors early and prevent them in the future.
Future Improvements
The paths are currently optimized for amount of workflows running. Example: a change in schema will trigger api-client
only and not workflows for platform and cli.
Developer's checklist
PR Type
Enhancement
Description
Changes walkthrough 📝
validate-api-client.yaml
Add schema package dependency to API client workflow
.github/workflows/validate-api-client.yaml
validate-cli.yaml
Add API client and secret scan dependencies to CLI workflow
.github/workflows/validate-cli.yaml
paths
validate-platform.yaml
Add API client dependency to platform workflow
.github/workflows/validate-platform.yaml