From 0aed132d47921b95a3e6bb0e68aad63ce61759c7 Mon Sep 17 00:00:00 2001 From: muntaxir4 Date: Wed, 18 Dec 2024 04:24:40 +0530 Subject: [PATCH 1/3] feat(workflows): Add internal package deps to existing workflows --- .github/workflows/validate-api-client.yaml | 12 ++++++++++-- .github/workflows/validate-cli.yaml | 4 ++++ .github/workflows/validate-platform.yaml | 4 +++- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/.github/workflows/validate-api-client.yaml b/.github/workflows/validate-api-client.yaml index 4d336299..eabca359 100644 --- a/.github/workflows/validate-api-client.yaml +++ b/.github/workflows/validate-api-client.yaml @@ -6,10 +6,18 @@ on: - '!develop' - '!main' paths: - ['packages/api-client/**', '.github/workflows/validate-api-client.yml'] + [ + 'packages/schema/**', + 'packages/api-client/**', + '.github/workflows/validate-api-client.yml' + ] pull_request: paths: - ['packages/api-client/**', '.github/workflows/validate-api-client.yml'] + [ + 'packages/schema/**', + 'packages/api-client/**', + '.github/workflows/validate-api-client.yml' + ] jobs: validate: diff --git a/.github/workflows/validate-cli.yaml b/.github/workflows/validate-cli.yaml index 806f3901..49e67b26 100644 --- a/.github/workflows/validate-cli.yaml +++ b/.github/workflows/validate-cli.yaml @@ -7,6 +7,8 @@ on: - '!main' paths: [ + 'packages/api-client/**', + 'packages/secret-scan/**', 'apps/cli/**', '.github/workflows/validate-cli.yml', '.github/workflows/deploy-cli.yml' @@ -14,6 +16,8 @@ on: pull_request: paths: [ + 'packages/api-client/**', + 'packages/secret-scan/**', 'apps/cli/**', '.github/workflows/deploy-cli.yml', '.github/workflows/validate-cli.yml' diff --git a/.github/workflows/validate-platform.yaml b/.github/workflows/validate-platform.yaml index c29b2b67..c488d506 100644 --- a/.github/workflows/validate-platform.yaml +++ b/.github/workflows/validate-platform.yaml @@ -7,6 +7,7 @@ on: - '!main' paths: [ + 'packages/api-client/**', 'apps/platform/**', '.github/workflows/validate-platform.yml', '.github/workflows/deploy-platform.yml' @@ -14,6 +15,7 @@ on: pull_request: paths: [ + 'packages/api-client/**', 'apps/platform/**', '.github/workflows/deploy-platform.yml', '.github/workflows/validate-platform.yml' @@ -58,4 +60,4 @@ jobs: - name: Lint run: | - pnpm run lint:platform \ No newline at end of file + pnpm run lint:platform From c3b34c90c5f2a531e2b32a77b6fcdf0996671f84 Mon Sep 17 00:00:00 2001 From: muntaxir4 Date: Wed, 18 Dec 2024 04:43:37 +0530 Subject: [PATCH 2/3] fix(workflows): Rename yaml files from .yml to .yaml in their dep paths --- .github/workflows/validate-api-client.yaml | 4 ++-- .github/workflows/validate-api.yaml | 4 ++-- .github/workflows/validate-cli.yaml | 8 ++++---- .github/workflows/validate-platform.yaml | 8 ++++---- .github/workflows/validate-schema.yaml | 4 ++-- .github/workflows/validate-secret-scan.yaml | 4 ++-- .github/workflows/validate-web.yaml | 8 ++++---- 7 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/validate-api-client.yaml b/.github/workflows/validate-api-client.yaml index eabca359..6c1f229e 100644 --- a/.github/workflows/validate-api-client.yaml +++ b/.github/workflows/validate-api-client.yaml @@ -9,14 +9,14 @@ on: [ 'packages/schema/**', 'packages/api-client/**', - '.github/workflows/validate-api-client.yml' + '.github/workflows/validate-api-client.yaml' ] pull_request: paths: [ 'packages/schema/**', 'packages/api-client/**', - '.github/workflows/validate-api-client.yml' + '.github/workflows/validate-api-client.yaml' ] jobs: diff --git a/.github/workflows/validate-api.yaml b/.github/workflows/validate-api.yaml index ae187a18..8243e60f 100644 --- a/.github/workflows/validate-api.yaml +++ b/.github/workflows/validate-api.yaml @@ -5,9 +5,9 @@ on: branches: - '!develop' - '!main' - paths: ['apps/api/**', '.github/workflows/validate-api.yml'] + paths: ['apps/api/**', '.github/workflows/validate-api.yaml'] pull_request: - paths: ['apps/api/**', '.github/workflows/validate-api.yml'] + paths: ['apps/api/**', '.github/workflows/validate-api.yaml'] jobs: validate: diff --git a/.github/workflows/validate-cli.yaml b/.github/workflows/validate-cli.yaml index 49e67b26..7666d987 100644 --- a/.github/workflows/validate-cli.yaml +++ b/.github/workflows/validate-cli.yaml @@ -10,8 +10,8 @@ on: 'packages/api-client/**', 'packages/secret-scan/**', 'apps/cli/**', - '.github/workflows/validate-cli.yml', - '.github/workflows/deploy-cli.yml' + '.github/workflows/validate-cli.yaml', + '.github/workflows/deploy-cli.yaml' ] pull_request: paths: @@ -19,8 +19,8 @@ on: 'packages/api-client/**', 'packages/secret-scan/**', 'apps/cli/**', - '.github/workflows/deploy-cli.yml', - '.github/workflows/validate-cli.yml' + '.github/workflows/deploy-cli.yaml', + '.github/workflows/validate-cli.yaml' ] jobs: diff --git a/.github/workflows/validate-platform.yaml b/.github/workflows/validate-platform.yaml index c488d506..01e4e3e3 100644 --- a/.github/workflows/validate-platform.yaml +++ b/.github/workflows/validate-platform.yaml @@ -9,16 +9,16 @@ on: [ 'packages/api-client/**', 'apps/platform/**', - '.github/workflows/validate-platform.yml', - '.github/workflows/deploy-platform.yml' + '.github/workflows/validate-platform.yaml', + '.github/workflows/deploy-platform.yaml' ] pull_request: paths: [ 'packages/api-client/**', 'apps/platform/**', - '.github/workflows/deploy-platform.yml', - '.github/workflows/validate-platform.yml' + '.github/workflows/deploy-platform.yaml', + '.github/workflows/validate-platform.yaml' ] jobs: diff --git a/.github/workflows/validate-schema.yaml b/.github/workflows/validate-schema.yaml index e46b437c..9719e7e3 100644 --- a/.github/workflows/validate-schema.yaml +++ b/.github/workflows/validate-schema.yaml @@ -5,9 +5,9 @@ on: branches: - '!develop' - '!main' - paths: ['packages/schema/**', '.github/workflows/validate-schema.yml'] + paths: ['packages/schema/**', '.github/workflows/validate-schema.yaml'] pull_request: - paths: ['packages/schema/**', '.github/workflows/validate-schema.yml'] + paths: ['packages/schema/**', '.github/workflows/validate-schema.yaml'] jobs: validate: diff --git a/.github/workflows/validate-secret-scan.yaml b/.github/workflows/validate-secret-scan.yaml index dacc5ce0..83fea21d 100644 --- a/.github/workflows/validate-secret-scan.yaml +++ b/.github/workflows/validate-secret-scan.yaml @@ -6,10 +6,10 @@ on: - '!develop' - '!main' paths: - ['packages/secret-scan/**', '.github/workflows/validate-secret-scan.yml'] + ['packages/secret-scan/**', '.github/workflows/validate-secret-scan.yaml'] pull_request: paths: - ['packages/secret-scan/**', '.github/workflows/validate-secret-scan.yml'] + ['packages/secret-scan/**', '.github/workflows/validate-secret-scan.yaml'] jobs: validate: diff --git a/.github/workflows/validate-web.yaml b/.github/workflows/validate-web.yaml index f396b437..73ab67ff 100644 --- a/.github/workflows/validate-web.yaml +++ b/.github/workflows/validate-web.yaml @@ -8,15 +8,15 @@ on: paths: [ 'apps/web/**', - '.github/workflows/validate-web.yml', - '.github/workflows/deploy-web.yml' + '.github/workflows/validate-web.yaml', + '.github/workflows/deploy-web.yaml' ] pull_request: paths: [ 'apps/web/**', - '.github/workflows/deploy-web.yml', - '.github/workflows/validate-web.yml' + '.github/workflows/deploy-web.yaml', + '.github/workflows/validate-web.yaml' ] jobs: From b7eaacafc645d951912f1e714c2957f6bb799ea4 Mon Sep 17 00:00:00 2001 From: muntaxir4 Date: Wed, 18 Dec 2024 19:47:25 +0530 Subject: [PATCH 3/3] fix: Update lint command for secret-scan --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3608c233..f0926c15 100644 --- a/package.json +++ b/package.json @@ -101,7 +101,7 @@ "lint:platform": "turbo run lint --filter=platform", "lint:cli": "turbo run lint --filter=cli", "lint:api-client": "turbo run lint --filter=@keyshade/api-client", - "lint:secret-scan": "turbo run lint --filter=secret-scan", + "lint:secret-scan": "turbo run lint --filter=@keyshade/secret-scan", "lint:schema": "turbo run lint --filter=@keyshade/schema", "build": "turbo run build", "build:api": "pnpm db:generate-types && turbo run build --filter=api",