-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AGP 8.0+ #411
base: master
Are you sure you want to change the base?
Support AGP 8.0+ #411
Conversation
@aasitnikov I have an error: Cause: {module_name} module's AndroidManifest not found. |
same for me the first lib i do |
@aasitnikov Hello, there are problems (AGP: 8.0.2, Gradle: 8.1.1) Configuration 'embed' was resolved during configuration time.
FAILURE: Build failed with an exception.
AGP: 7.2.0, Gradle: 7.6: Works without errors |
Hi @aasitnikov, i tried to update my fork with your changes but unfortunately i do get the same error that others reported as soon as i use AGP 8.0.0 or higher. After a first look it looks like you are trying to access the AndroidManifest of the exploded aar before you explode the aar. Maybe you have an idea how to resolve this error. Best regards, |
I figured out potential issue, try "com.github.aasitnikov:fat-aar-android:b2a038763c" to see if it works for you |
Merged into an off-site repo, builds are successful. Thank you for bothering to fix what Google won't even develop. |
Thanks a lot @aasitnikov ! I used AGP 8.1.1 and gradle 8.3 and it's working fine now. |
Thanks for the fix! Successfully used in gradle 8.3 :D |
If you struggle with connecting this fix via Kotlin DSL use this approach:
In the root build.gradle.kts you have to use the old buildScript approach because I haven't figured out how to find plugin ID to add it to the plugins block.
Finally, add the plugin in build.gradle.kts of your module.
|
@flasher297 |
Hi @aasitnikov. Try you patch on my project. Versions: Looks like result |
Thank you @aasitnikov it's working. |
Works for me!: gradle 8.0 And here is my changed files: root settings.gradle pluginManagement {
repositories {
...
maven { url 'https://jitpack.io' }
...
}
} root build.gradle buildscript{
dependencies {
// classpath 'com.github.kezong:fat-aar:1.3.8'
classpath("com.github.aasitnikov:fat-aar-android:b2a038763c")
}
}
// Top-level build file where you can add configuration options common to all sub-projects/modules.
plugins {
...
} the sdk need embed. build.gradle plugins {
...
id 'com.kezong.fat-aar'
} |
@dyguests 老哥,我的依然没成功,能留个联系方式交流交流吗 |
我上面的回复,已经是我全部修改内容啦 ,没别的办法啦。 |
@aasitnikov today i tried updating to gradle 8.6 and it does not work anymore. Can you maybe also fix it for 8.6? |
@TVDiasDominik you can try my fork https://github.com/lsuski/fat-aar-android/tree/support_gradle86 |
Support AGP 8.3.1 ? |
Try out https://github.com/aasitnikov/fat-aar-android with AGP 8.3.0 support |
dependencies依赖的还是用embed project吗? |
|
@jike1502jt 我真不知道了。 |
fat-aar 不是不支持gradle8以上吗? |
Support AGP 8.5.x ? |
Try out latest release with AGP 8.5 support at https://github.com/aasitnikov/fat-aar-android |
This pull request adds support for AGP 8.0.
Note that this branch includes fix from #403.
To get this version into your project, you can use jitpack as follows: