Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undo no longer works with new ID system #21

Open
kfarr opened this issue Jun 7, 2017 · 0 comments
Open

undo no longer works with new ID system #21

kfarr opened this issue Jun 7, 2017 · 0 comments

Comments

@kfarr
Copy link
Owner

kfarr commented Jun 7, 2017 •
edited
Loading

after this commit to enable erase feature: 84f5a2c

it was necessary to change to uuid when creating new objects, discussion here: #20

this breaks the existing undo feature which simply looked for the ID 1 less than the value of the total number of city objects (https://github.com/kfarr/aframe-city-builder/blob/master/lib/builder-controls.js#L250).

undo should be fixed to support the new uuid system
@kfarr kfarr added the bug label Jun 7, 2017
@kfarr kfarr removed the bug label Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kfarr