Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with XML test cases #104

Open
1 of 3 tasks
chrdebru opened this issue Feb 28, 2024 · 8 comments
Open
1 of 3 tasks

Issues with XML test cases #104

chrdebru opened this issue Feb 28, 2024 · 8 comments
Assignees
Labels
pending Waiting for another spec or issue to be ready test-cases Test cases need to be updated

Comments

@chrdebru
Copy link
Contributor

chrdebru commented Feb 28, 2024

@DylanVanAssche
Copy link
Collaborator

  • No test case for testing selecting values from attributes: +1, feel free to add it if you have one.
  • Should we have a test case for selecting elements based on conditions?: Tricky XPath is welcome I suppose? People do tricky stuff with it so we should check it?
  • More test cases for language maps? E.g., ensuring no terms are generated when the language map does not yield terms.: For now we have the basics, but there might be corner cases left open, so all help is welcome. This is mostly for the maintainers to figure out?

@chrdebru
Copy link
Contributor Author

I agree. I can add a test case for the first if @pmaria and @andimou agree that selecting attributes must use valid XPath queries.

@chrdebru
Copy link
Contributor Author

chrdebru commented Mar 4, 2024

@DylanVanAssche : The first should be solved with #107.

@pmaria pmaria added the test-cases Test cases need to be updated label Jun 25, 2024
@dachafra
Copy link
Member

dachafra commented Jul 4, 2024

I agree with @chrdebru on both pending tasks.

I also have many use cases with very tricky XPath expressions, that currently are not supported by many engines.

My question is: do we need them now? If yes, who wants to create them? If not, I'll mark it as working-group @DylanVanAssche @chrdebru

@pmaria
Copy link
Collaborator

pmaria commented Jul 4, 2024

  • Should we have a test case for selecting elements based on conditions?

I also have many use cases with very tricky XPath expressions, that currently are not supported by many engines.

These would fit best in the io-registry IMHO.

@DylanVanAssche
Copy link
Collaborator

I agree with @pmaria Tricky XPath expressions need to be specified and tested in rml-io-registry.
We need to collect them first to have a good idea of what is called 'tricky' as that's very vague currently.

@dachafra
Copy link
Member

dachafra commented Jul 5, 2024

More test cases for language maps? E.g., ensuring no terms are generated when the language map does not yield terms..

and what about the second? Do we need it? @DylanVanAssche

@DylanVanAssche
Copy link
Collaborator

and what about the second? Do we need it?

Depends if the spec requires that if no language tag is generated for the triple while there's a language map, that we don't generate a triple --> basic reference algorithm + spec definition is needed.

@dachafra dachafra added the pending Waiting for another spec or issue to be ready label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Waiting for another spec or issue to be ready test-cases Test cases need to be updated
Projects
None yet
Development

No branches or pull requests

5 participants