Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency due to rdfs:domain of rml:logicalTarget and its use on rml:LanguageMap #61

Open
pmaria opened this issue Mar 18, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@pmaria
Copy link
Contributor

pmaria commented Mar 18, 2024

The rdfs:domain of rml:logicalTarget is defined to be rml:TermMap, yet it is also used on rml:LanguageMap which is not a rml:TermMap.

Options:

  • drop the domain for rml:logicalTarget
  • make the domain a union of rml:TermMap and rml:LanguageMap
@DylanVanAssche DylanVanAssche added the bug Something isn't working label Mar 18, 2024
@andimou
Copy link

andimou commented Mar 18, 2024

couldn't we have another option to have the domain as rml:ExpressionMap?

@pmaria
Copy link
Contributor Author

pmaria commented Mar 19, 2024

couldn't we have another option to have the domain as rml:ExpressionMap?

That would be too broad, since there are expression maps that do not directly cause the generation of a term (part), like rml:ChildMap and rml:ParentMap.

@anaigmo
Copy link
Contributor

anaigmo commented Mar 19, 2024

I agree with @pmaria in this, to have as domain the union of both instead of rml:ExpressionMap is more accurate. I'll add this and the other pending changes to the IO ontology this week

@andimou
Copy link

andimou commented Mar 19, 2024

right and what about the DatatypeMap? I.e. why only the LanguageMap and not the DatatypeMap?

@pmaria
Copy link
Contributor Author

pmaria commented Mar 19, 2024

Yes, good question. I think we can see DatatypeMap as a TermMap in the sense that it always generates an IRI. It definitely also generates a part of a literal term. I don't believe we currently classed it as a TermMap. So maybe we should raise an issue for this.

@andimou
Copy link

andimou commented Mar 19, 2024

that's an interesting observation, 👍 on raising an issue for this.

I didn't exactly mean this though 😅 I meant a union of rml:TermMap, rml:LanguageMap and rml:DatatypeMap.
If one can define a larget in the rml:LanguageMap, then it should be the same for a rml:DatatypeMap no?

@pmaria
Copy link
Contributor Author

pmaria commented Mar 19, 2024

I agree, we should also be able to define a target on a rml:DatatypeMap if we are allowing a target on a rml:LanguageMap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants