tree_icon improvement #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I am using this library for a work project and found improvements that are useful to me, so maybe you'll find them useful for others.
First, I find out you can write
icon-leaf="null"to have no icon for leaves. So I removed the link when there is no icon. (997c0b0)Then, I added the possibility to have an icon for the roots. (37da027)
In my project, the children are loaded after a server-side request, so I need to have an icon for the roots regardless if they have any children. When clicked it will send the request.
Thanks for reviewing my pull request. ;)