Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some booth locations at the Stardew Valley Fair appear to be changing #407

Closed
fz0308 opened this issue Sep 26, 2024 · 0 comments
Closed

Some booth locations at the Stardew Valley Fair appear to be changing #407

fz0308 opened this issue Sep 26, 2024 · 0 comments

Comments

@fz0308
Copy link

fz0308 commented Sep 26, 2024

I tried interacting with some of the booths at the Stardew Valley Fair, such as Fishing Challenge, Slingshot Game, Free Burgers, ETC, but nothing happened. Could the location of the booth change?
ParadoxiKat added a commit to ParadoxiKat/stardew-access that referenced this issue Jan 5, 2025
@ParadoxiKat
Refactor event tile logic and consolidate tile data
f5b07c2 
- **Unify tile data loading**:
  - Refactored event tile logic to load from the unified `tiles.json`, aligning it with how other static tiles are managed.

- **Remove obsolete configuration**:
  - Deleted `event-tiles.json` and removed related code from `DynamicTiles.cs`, eliminating redundancy and simplifying the codebase.

- **Integrate event-specific data**:
  - Moved event tile data into `tiles.json` under respective festival names, ensuring all tile definitions are centralized.
  - Relocated festival Fluent tokens to `static_tiles.en.ftl` to streamline localization processes.

- **Update naming references**:
  - Modified references from location names to event names where appropriate, enhancing clarity and consistency in tile identification.

Partially addresses khanshoaib3#420, khanshoaib3#407, khanshoaib3#311,  and khanshoaib3#225
ParadoxiKat added a commit to ParadoxiKat/stardew-access that referenced this issue Jan 5, 2025
@ParadoxiKat
Add support for generic tile actions, dynamic tile category mapping ,…
3a33db3 
… and dynamic event tile detection

- **Add `dynamic_tile_categories.json`** to `assets/TileData` to map dynamic tile fluent tokens to their respective categories.
- **Migrate fluent tokens** for Luau, Stardew Valley Fair, and Pierre's Booth from static definitions to dynamic tiles.
- **Introduce dynamic tile fluent tokens**:
  - For Egg Festival eggs.
  - Modify Tourist fluent token to accept a number for enumerating tourists during Stardew Valley Fair.
- **Enhance tile action detection**:
  - Add support for detecting tile actions across maps.
  - Introduce new handlers (`GetTileActionInfo`, `GetDefaultTileActionInfo`) and update existing function signatures to accommodate the new string argument.
- **Implement `GetDynamicTileFluentToken`** in `DynamicTiles.cs` to auto-generate fluent tokens based on location and tile actions.
- **Integrate `dynamic_tile_categories.json`** into dynamic tiles processing for category mapping.
- **Improve dynamic detection** of the Traveling Cart location in the Forest.
- **Create custom handlers** for Stardew Valley Fair and Festival of Ice events to detect shops and other points of interest.
- **Add documentation**:
- **Cleanup**:
  - Remove obsolete static tile definitions from `tiles.json` to prevent redundancy and potential conflicts.

This should improve the overall tile tracking system and end user experience.
Progresses khanshoaib3#225 by tracking event tiles dynamically
Closes  khanshoaib3#407
Closes khanshoaib3#420
ParadoxiKat added a commit to ParadoxiKat/stardew-access that referenced this issue Jan 6, 2025
@ParadoxiKat
Refactor event tile logic and consolidate tile data
771f6fd 
- **Unify tile data loading**:
  - Refactored event tile logic to load from the unified `tiles.json`, aligning it with how other static tiles are managed.

- **Remove obsolete configuration**:
  - Deleted `event-tiles.json` and removed related code from `DynamicTiles.cs`, eliminating redundancy and simplifying the codebase.

- **Integrate event-specific data**:
  - Moved event tile data into `tiles.json` under respective festival names, ensuring all tile definitions are centralized.
  - Relocated festival Fluent tokens to `static_tiles.en.ftl` to streamline localization processes.

- **Update naming references**:
  - Modified references from location names to event names where appropriate, enhancing clarity and consistency in tile identification.

Partially addresses khanshoaib3#420, khanshoaib3#407, khanshoaib3#311,  and khanshoaib3#225
ParadoxiKat added a commit to ParadoxiKat/stardew-access that referenced this issue Jan 6, 2025
@ParadoxiKat
Add support for generic tile actions, dynamic tile category mapping ,…
3885b93 
… and dynamic event tile detection

- **Add `dynamic_tile_categories.json`** to `assets/TileData` to map dynamic tile fluent tokens to their respective categories.
- **Migrate fluent tokens** for Luau, Stardew Valley Fair, and Pierre's Booth from static definitions to dynamic tiles.
- **Introduce dynamic tile fluent tokens**:
  - For Egg Festival eggs.
  - Modify Tourist fluent token to accept a number for enumerating tourists during Stardew Valley Fair.
- **Enhance tile action detection**:
  - Add support for detecting tile actions across maps.
  - Introduce new handlers (`GetTileActionInfo`, `GetDefaultTileActionInfo`) and update existing function signatures to accommodate the new string argument.
- **Implement `GetDynamicTileFluentToken`** in `DynamicTiles.cs` to auto-generate fluent tokens based on location and tile actions.
- **Integrate `dynamic_tile_categories.json`** into dynamic tiles processing for category mapping.
- **Improve dynamic detection** of the Traveling Cart location in the Forest.
- **Create custom handlers** for Stardew Valley Fair and Festival of Ice events to detect shops and other points of interest.
- **Add documentation**:
- **Cleanup**:
  - Remove obsolete static tile definitions from `tiles.json` to prevent redundancy and potential conflicts.

This should improve the overall tile tracking system and end user experience.
Progresses khanshoaib3#225 by tracking event tiles dynamically
Closes  khanshoaib3#407
Closes khanshoaib3#420
ParadoxiKat added a commit to ParadoxiKat/stardew-access that referenced this issue Jan 7, 2025
@ParadoxiKat
Refactor event tile logic and consolidate tile data
8c1b4e2 
- **Unify tile data loading**:
  - Refactored event tile logic to load from the unified `tiles.json`, aligning it with how other static tiles are managed.

- **Remove obsolete configuration**:
  - Deleted `event-tiles.json` and removed related code from `DynamicTiles.cs`, eliminating redundancy and simplifying the codebase.

- **Integrate event-specific data**:
  - Moved event tile data into `tiles.json` under respective festival names, ensuring all tile definitions are centralized.
  - Relocated festival Fluent tokens to `static_tiles.en.ftl` to streamline localization processes.

- **Update naming references**:
  - Modified references from location names to event names where appropriate, enhancing clarity and consistency in tile identification.

Partially addresses khanshoaib3#420, khanshoaib3#407, khanshoaib3#311,  and khanshoaib3#225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fz0308