Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressing x on animals provides a dialog that doesn't seem usable. #436

Open
stickbear2015 opened this issue Jan 1, 2025 · 17 comments
Open
Assignees
Labels
easy Good for newcomers enhancement New feature or request

Comments

@stickbear2015
Copy link

I've noticed that pressing X on animals such as cows, and chickens, pops up a dialog with what looks like an OK button. Attempting to navigate it with A S D and W gives no feedback that I can determine. I asked around and this dialog seems to be the dialog where you can move, or rename your animal, (cow, chicken, etc.) This dialog is from what I can see unusable at this current time, unless I'm missing something obvious.
I'm putting @khanshoaib3 as CC on this as this seems like something they can fix in the dialog code.

@danielw97
Copy link

I can reproduce this as well, thanks for flagging it up.
If memory serves, this dialogue may have been accessible for a time during SDV 1.5, and from memory it is mostly concerned with renaming/selling animals.

@danielw97
Copy link

Hi,
After testing this dialogue today, interestingly it is accessible again on my system.
I'm running the latest snapshot build from the actions page which is labeled as beta 6, as well as SDV 1.6.15.
Are you perhaps running a different version of the mod/game?

@stickbear2015
Copy link
Author

this has been tested with stardew valley steam release 1.6.15 build 24356 as well as stardew valley 1.6.15 gog build 24357 and on both versions have been tested with stardew access beta 6.5 that contains everything from @khanshoaib3's latest snapshot changes plus fixes from @ParadoxiKat and this issue still persists.

@khanshoaib3
Copy link
Owner

@danielw97 @stickbear2015 I can't reproduce this issue, and neither the skills tab one. I'll need the log files to debug this. And preferably use the debug build so it generates more logs.

@khanshoaib3 khanshoaib3 self-assigned this Jan 4, 2025
@khanshoaib3 khanshoaib3 added enhancement New feature or request easy Good for newcomers labels Jan 4, 2025
@danielw97
Copy link

@khanshoaib3 okay, this is interesting.
I've tried without having space core installed, and the skills menu now works.
Looking at the logs when space core is installed, I get this error:

[Stardew Access] Simulating left mouse click at 696x 264y                                                               
[Stardew Access] [IClickableMenuPatch.DrawPatch] Attempting to patch menu {ManuallyCalled:False}: SpaceCore.Interface.NewSkillsPage                                                                                                             
[Stardew Access] [ClickableComponentUtils] Fields found to check and narrate, menu in question: SpaceCore.Interface.NewSkillsPage                                                                                                               
System.Collections.Generic.List`1[StardewValley.Menus.ClickableTextureComponent]        skillBars                       
System.Collections.Generic.List`1[StardewValley.Menus.ClickableTextureComponent]        skillAreas                      
StardewValley.Menus.ClickableComponent  playerPanel                                                                     
StardewValley.Menus.ClickableTextureComponent   upButton                                                                
StardewValley.Menus.ClickableTextureComponent   downButton                                                              
StardewValley.Menus.ClickableTextureComponent   scrollBar                                                               
StardewValley.Menus.ClickableComponent  lastSnappedComponent                                                            
StardewValley.Menus.ClickableTextureComponent   upperRightCloseButton                                                   

Unfortunately I'm struggling to reproduce the inaccessible animal menu, as that now works on both my machines so @stickbear2015 may have to provide a log for this.

@stickbear2015
Copy link
Author

I don't know what the skills issue is as it's not in this issue, let's just concintrate on what this issue references, please. The skills issue and the associated log entry should be migrated to it's own issue to keep things organized.
@danielw97 you say the animals dialog works now? What changed between when it didn't vs. when it did?
Did you remove space core and it worked?
I'll have to remember what space core offers, and if it'd be safe to remove it.
If it is, I'll remove it and ask @jamminjerry2022 to remove it as well to see if that fixes the animals dialog. I wouldn't expect so, but it's worth trying.
In order to get a debug build, I'll ask @ParadoxiKat if she can generate one for me.

@stickbear2015
Copy link
Author

oh, @khanshoaib3 @danielw97 it looks like the skills issue was fixed in #432

@danielw97
Copy link

@stickbear2015 apologies, that's what I get for replying via email so you can disregard the skills menu issue.
I'm struggling to pin down exactly what changed to get the animal menu working, as initially it was only working on one computer but not the other.
Annoyingly, now that it is working for meI can't debug what the problem might be.
Your best bet would be to try to get a debug build, and post a log if you can to pin down where the issue might be for you.
That way we can see if it's a space core or other issue.

@jamminjerry2022
Copy link

jamminjerry2022 commented Jan 4, 2025 via email

@stickbear2015
Copy link
Author

I've got log and mp3 data for this issue, thanks to @jamminjerry2022.
I will attach the complete log file. you will see it shows him moving to the different options, but, when you listen to the mp3 file, you will only hear it read one option, the pregnancy one.
[14:15:48 DEBUG Stardew Access] Category: Animals | Object: patty, White Cow, 22 days
[14:15:49 DEBUG Stardew Access] [IClickableMenuPatch.DrawPatch] Attempting to patch menu {ManuallyCalled:False}: AnimalHusbandryMod.animals.AnimalQueryMenuExtended
[14:15:49 DEBUG Stardew Access] [ClickableComponentUtils] Fields found to check and narrate, menu in question: AnimalHusbandryMod.animals.AnimalQueryMenuExtended
StardewValley.Menus.ClickableTextureComponent pregnantStatus
StardewValley.Menus.ClickableTextureComponent treatStatus
StardewValley.Menus.ClickableTextureComponent meatButton
StardewValley.Menus.ClickableTextureComponent animalContestIndicator
StardewValley.Menus.ClickableTextureComponent okButton
StardewValley.Menus.ClickableTextureComponent love
StardewValley.Menus.ClickableTextureComponent sellButton
StardewValley.Menus.ClickableTextureComponent moveHomeButton
StardewValley.Menus.ClickableTextureComponent yesButton
StardewValley.Menus.ClickableTextureComponent noButton
StardewValley.Menus.ClickableTextureComponent allowReproductionButton
StardewValley.Menus.ClickableComponent loveHover
StardewValley.Menus.ClickableComponent textBoxCC
StardewValley.Menus.ClickableTextureComponent upperRightCloseButton
[14:16:16 DEBUG Stardew Access] Game1Patch: Closing AnimalHusbandryMod.animals.AnimalQueryMenuExtended menu, performing cleanup...
[14:16:16 DEBUG Stardew Access] Switched from AnimalHusbandryMod.animals.AnimalQueryMenuExtended menu, performing cleanup...
[14:16:22 TRACE game] Disconnected: ClosedGame
[14:16:22 TRACE SMAPI] Disposing...
[14:16:22 TRACE SMAPI] Disposing the content coordinator. Content managers will no longer be usable after this point.
Here's the complete log file
complete log file
Here's the mp3 file.
mp3 of the issue in question
note: the files are coming from dropbox.

@danielw97
Copy link

This is interesting. Looking at the log, it appears as though the Animal Husbandry mod has a custom "extended" menu that I assume hasn't been patched.
At the moment, most if not all menus require patches to be written for them.
Might you please be willing to try without this mod to see if that fixes the problem?

@stickbear2015
Copy link
Author

ok, @jamminjerry2022 re-did the mp3 file, talking you through things. here's
an updated mp3

@jamminjerry2022
Copy link

jamminjerry2022 commented Jan 4, 2025 via email

@jamminjerry2022
Copy link

jamminjerry2022 commented Jan 4, 2025 via email

@stickbear2015
Copy link
Author

@danielw97 I removed it and PolyamorySweet as well, and as @jamminjerry2022 said, AnimalHusbandryMod was the culprit.

@danielw97
Copy link

Glad to hear it.
I'm not sure how many folks use that particular mod and what @khanshoaib3's stance on third party menu patching is, but if you're interested we can certainly have a discussion to see what needs to be done to patch that menu as it does look like an interesting addition for those of us who focus on raising animals more.
Glad we figured out the problem, though.

@stickbear2015
Copy link
Author

I'd like to see that menu get patched, if it's patchable, @khanshoaib3 is this something that's patchable? I've removed the mod temporarily, and I've informed at least the two I know that use it, that this is a patch issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Good for newcomers enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants