Skip to content
This repository has been archived by the owner on Aug 28, 2018. It is now read-only.

Bundle maintenance #23

Open
viliam-husar opened this issue Jan 21, 2013 · 3 comments
Open

Bundle maintenance #23

viliam-husar opened this issue Jan 21, 2013 · 3 comments

Comments

@viliam-husar
Copy link

HI,
I really like your bundle and have some ideas how to improve it.

  • fix coding standards,
  • allow service calls before and after fixtures file is loaded (not after object is persisted)
  • normalize tests,
  • add other loaders (maybe XML?)
  • add configuration option to fixtures file to define which fixtures should be loaded before... (order by filenames is very hard to maintain when there a lot of fixtures).

So, consider this issue as discussion (i couldn't find your email). If you agree I can start to implement them.

@khepin
Copy link
Owner

khepin commented Jan 22, 2013

Hey, I'm 100% for it.

  • CS: sure, would be good
  • service calls: can't remember very precisely how it worked, have to look at it again
  • Tests: sure, I love tests!
  • Loaders: AWESOME (but we might need a name change for the bundle...)
  • Loading order: I thought people would've asked me that a long time ago but nope, so never did it, was planned as a todo from day 1.

Just to say that anything that can make this bundle better is great. As long as it stays simple and focused.

@khepin
Copy link
Owner

khepin commented Feb 18, 2013

I've added support for the loading order.

I'd really like to merge your PR for loading files if you can add some tests for it.
I'm really taking care of this bundle and so it's important for me that there are tests for everything possible.

@lenardpalko
Copy link
Collaborator

I think it would be a better idea to slpit this issue in several so we can track the advancement of them :

So I guess this issue can be closed @khepin ?

This was referenced Dec 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants