Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most recent datomic release (0.9.5561.50) pull rules are throw exception on db-diff #2

Open
bjconlan opened this issue Jun 20, 2017 · 0 comments

Comments

@bjconlan
Copy link

bjconlan commented Jun 20, 2017

When performing a db-diff using the latest datomic release I discovered that the db-diff function doesn't complete as expected due to an exception.

CompilerException java.lang.IllegalArgumentException: :db.error/not-a-keyword Cannot interpret as a keyword: Documentation string for an entity., no leading :, compiling:(/home/bjc/Workspace/wonderdrug/maestro/src/clj/maestro/datomic/migrations.clj:14:13)
This looks to be because the pull rule used by get-attributes defines a :db/doc [:db/ident].

This used to simply be ignored but as per more recent releases (see https://groups.google.com/forum/#!topic/datomic/F9-9KkKTSiE) this behavior has changed and causes an exception.

Changing the pull shape found at https://github.com/kibu-australia/rawat/blob/master/src/rawat/core.cljc#L213 to:

[:db/ident :db/unique :db/index :db/fulltext :db/isComponent :db/noHistory {:db/valueType [:db/ident] :db/cardinality [:db/ident]} :db/doc]

looks to resolve the problem (although I fear perhaps cause regressions in older datomic instances).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant