[MBL-1852] Update CreateBackingInput #2203
Open
+654
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
force-pushed
the
scott/mbl-1852
branch
from
125e125 to
81ea7ba
Compare
Generated by 🚫 Danger |
scottkicks
changed the title
ifosli
approved these changes
Nov 25, 2024
| @@ -15,6 +16,7 @@ public struct CreateBackingInput: GraphMutationInput, Encodable { | |||
|
|
|||
| - parameter amount: The amount. | |||
| - parameter applePay: The optional ApplePayParams. | |||
| - parameter incremental: The optional Bool indicating whether pledge over time has been selected.. | |||
There was a problem hiding this comment.
Should there be a test where incremental is true?
There was a problem hiding this comment.
Definitely. My plan is to add tests when I get going on the implementation piece.
stevestreza-ksr
approved these changes
Dec 3, 2024
| @@ -521,7 +521,8 @@ public class NoShippingPledgeViewModel: NoShippingPledgeViewModelType, NoShippin | |||
| paymentSourceId: paymentSourceId, | |||
| setupIntentClientSecret: nil, | |||
| applePayParams: applePayParams, | |||
| refTag: refTag | |||
| refTag: refTag, | |||
| incremental: false // TODO: implementation in [mbl-1853](https://kickstarter.atlassian.net/browse/MBL-1853) | |||
There was a problem hiding this comment.
It looks like incremental is always false in this PR, is the idea to make it true sometimes in that ticket?
There was a problem hiding this comment.
Yeah! Just exposing the Boolean here. Wiring it up to the PLOT component will be done in that ticket in the inline comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Updates the
CreateBackingInputGraphQL object to support its newincremental: Bool?property.Actual implementation will be done separately in mbl-1853.
🤔 Why
This flag will let the backend know if backers have selected the Pledge Over Time option at checkout.
🛠 How
falseto call points for now since implementation will be done in mbl-1853👀 See
Tested that the new property is being sent as false in when attempting a crowdfund pledging:
✅ Acceptance criteria
incrementalis being added to theCreateBackingInputand is false for now.