Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-1860] PLOT String Translations #2217

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[MBL-1860] PLOT String Translations #2217

wants to merge 4 commits into from
+383 −75

Conversation

scottkicks
Copy link
Contributor

🤔 Why

There's new copy being added for our PLOT feature.

🛠 How

  • Run make strings and verify that all localized string files are updated with the correct strings.
  • Note that this script pulls in all of the latest string updates, so a few in this PR aren't relevant to PLOT.

⏰ TODO

  • Inform the team that new strings are accessible and ready to be used instead of hard coded strings.

@scottkicks scottkicks self-assigned this Dec 10, 2024
@scottkicks scottkicks marked this pull request as ready for review December 11, 2024 17:51
@scottkicks scottkicks requested review from jovaniks and a team December 11, 2024 17:51
@scottkicks scottkicks requested review from amy-at-kickstarter and removed request for a team December 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovaniks jovaniks Awaiting requested review from jovaniks

@amy-at-kickstarter amy-at-kickstarter Awaiting requested review from amy-at-kickstarter

At least 1 approving review is required to merge this pull request.

Assignees

@scottkicks scottkicks

Labels
Pledge Over Time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@scottkicks