[MBL-1816] PLOT Ineligible state #2220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jluna/MBL-1816/plot-ineligible-state # Conflicts: # Kickstarter-iOS/Features/PledgeOverTime/Views/PledgePaymentPlanOptionView.swift # Library/ViewModels/NoShippingPledgeViewModel.swift # Library/ViewModels/PledgePaymentPlansViewModel.swift
jovaniks
changed the base branch from
main
to
jluna/MBL-1815/plot-plan-selector-selected-state
scottkicks
approved these changes
Dec 11, 2024
Kickstarter-iOS/Features/PledgeOverTime/Views/PledgePaymentPlanOptionView.swift
Outdated
Show resolved
Hide resolved
| @@ -174,6 +205,7 @@ final class PledgePaymentPlanOptionView: UIView { | |||
| self.titleLabel.rac.text = self.viewModel.outputs.titleText | |||
|
|
|||
| self.subtitleLabel.rac.text = self.viewModel.outputs.subtitleText | |||
| self.subtitleLabel.isHidden = true | |||
There was a problem hiding this comment.
This can probably go in applySubtitleLabelStyle with the other styles.
Kickstarter-iOS/Features/PledgeOverTime/Views/PledgePaymentPlanOptionView.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/PledgeOverTime/Views/PledgePaymentPlanOptionView.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/PledgeOverTime/Views/PledgePaymentPlanOptionView.swift
Outdated
Show resolved
Hide resolved
…jluna/MBL-1816/plot-ineligible-state # Conflicts: # Library/ViewModels/NoShippingPledgeViewModel.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
This PR implements the "PLOT ineligible" state for the Payment Plan Selector. It disables the "Pledge Over Time" option when the total pledge amount is below the threshold of $150.00 and displays a note indicating the ineligibility, with the amount converted using the project’s currency.
🤔 Why
The "PLOT is NOT eligible" state ensures backers understand why the "Pledge Over Time" option is unavailable. This limitation is based on the total pledge amount being below the required threshold of $150.00. By providing clear feedback, users are informed of the eligibility requirements.
🛠 How
Adding the new field
ineligibletoPledgePaymentPlanOptionDataandPledgePaymentPlansAndSelectionData👀 See
✅ Acceptance criteria
⏰ TODO