Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch comparison improvements #47

Open
Ginxo opened this issue Nov 18, 2022 · 0 comments
Open

branch comparison improvements #47

Ginxo opened this issue Nov 18, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ginxo
Copy link
Collaborator

Ginxo commented Nov 18, 2022

Caused by #44

  • add popover for the swap button, something like "Swap left and right branches, remember the order matters here"
  • add popover for the number just to the right of the branch selector on the header, something like "The number of different files comparing branch from the left and the right"
  • add popover for the Number of Differences from every repository, something like "The number of different files comparing branch from the left and the right"
  • solve UX issue for the GAP while data is loading (use loading from redux data.service), it only happens when there are branches to compare information. I would suggest to show a kind of scaffolding occupying same space as the expected final component (selector and so on). Steps to reproduce it
    • Open the webapp
    • wait until the whole page is loaded
    • open browser's developer tools
    • Go to network tab and select "2G Regular" (or even 3G) throttling
    • click on Reload button
    • the selectors do not appear until data is loaded

Firefox_Screenshot_2022-11-18T10-07-01 808Z
Firefox_Screenshot_2022-11-18T10-07-51 828Z

@Ginxo Ginxo added enhancement New feature or request good first issue Good for newcomers labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants