Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 19 #716

Open
1 of 3 tasks
praseodym opened this issue Dec 9, 2024 · 0 comments
Open
1 of 3 tasks

Upgrade to React 19 #716

praseodym opened this issue Dec 9, 2024 · 0 comments
Labels
frontend Issues or pull requests that relate to the frontend javascript Pull requests that update Javascript code

Comments

@praseodym
Copy link
Contributor

praseodym commented Dec 9, 2024 •
edited
Loading

Originally posted in #707 (comment)

Upgrading to React 19 currently breaks npm install:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: [email protected]
npm warn Found: [email protected]
npm warn node_modules/react
npm warn   react@"^19.0.0" from the root project
npm warn   9 more (@ladle/react, @ladle/react-context, @mdx-js/react, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^16.8.4 || ^17.0.0 || ^18.0.0" from [email protected]
npm warn node_modules/@ladle/react/node_modules/react-inspector
npm warn   react-inspector@"^6.0.2" from @ladle/[email protected]
npm warn   node_modules/@ladle/react
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/react
npm warn   peer react@"^16.8.4 || ^17.0.0 || ^18.0.0" from [email protected]
npm warn   node_modules/@ladle/react/node_modules/react-inspector
npm warn     react-inspector@"^6.0.2" from @ladle/[email protected]
npm warn     node_modules/@ladle/react

Ladle (@ladle/react) depends on react-inspector which doesn't support React 19 and hasn't seen any releases since June 2023. This means there is no way for us to upgrading to React 19 without breaking Ladle.

Maybe useful for automatic code updates: https://github.com/reactjs/react-codemod
This was referenced Dec 9, 2024
Merged
Closed
@praseodym praseodym changed the title Upgrade to React v19 Upgrade to React 19 Dec 9, 2024
@praseodym praseodym added frontend Issues or pull requests that relate to the frontend javascript Pull requests that update Javascript code labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Issues or pull requests that relate to the frontend javascript Pull requests that update Javascript code
Projects
Abacus Development
Status: Options
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/716-react-19 kiesraad/abacus
1 participant
@praseodym