Possible to use without Hiredis?

[pehrlich2]

Hello!

Doing first-time setup here. Following the given installation instructions on ruby 3.2.2 and either OSX or Heroku, I get the following error when starting the server:

LoadError: cannot load such file -- redis/connection/hiredis

Any tips for how to troubleshoot this? Is it possible to opt out of Hiredis, even temporarily? Thanks!

[pehrlich2]

Looks like this may be the root cause - perhaps there are some minor changes required on the side of simple-feed for compatibility here redis/redis-rb#1178

Edit: seems like editing lib/simplefeed/providers/redis/driver.rb to comment out require 'redis/connection/hiredis' and instead put require "hiredis-client" seems to get my app to boot. It will take a little more time to know if it seems to work as this gem is new to me!

[kigster]

@pehrlich2 thank you so much for reporting this. I would like to clarify your request:

• Would you rather see hiredis be optional or
• do I simply need to change the require to match the recent changes in the hiredis gem?

The reason for hiredis to begin with is that it provides a much faster communications with the redis server, where the most high throughput functions are written in plain C.

Let me know!

[pehrlich2]

Hi! I think it would be fine to simply update the require statement - as long as that doesn’t cause new problems. Have been using it that way and no trouble so far. Cheers

…

On Wed, May 10, 2023 at 12:08 PM Konstantin Gredeskoul < ***@***.***> wrote: @pehrlich2 <https://github.com/pehrlich2> *thank you so much for reporting this.* I would like to clarify your request: - Would you rather see hiredis be optional or - do I simply need to change the require to match the recent changes in the hiredis gem? The reason for hiredis to begin with is that it provides a much faster communications with the redis server, where the most high throughput functions are written in plain C. Let me know! — Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANFKKBKWTHOQ2FAEMI3GZTTXFO4O3ANCNFSM6AAAAAAXARXFBI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kigster]

Any chance you might be open to submitting a PR with your solution?

It be great if hiredis was optional, but the README explained how to enable it for high throughput.

[kigster]

Is this still an issue that need solving?

[bkmaibach]

Is this still an issue that need solving?

Yes please!

[bkmaibach]

If you are attempting to use this gem in rails without hiredis (standary ruby driver only) in rails with Redis >5 you can do the following:

Add the following line to boot.rb:
$LOAD_PATH.unshift(File.expand_path('../../lib/overrides', FILE))

And then add an empty file at:
lib/overrides/redis/connection/hiredis.rb

[kigster]

Thanks. I'll release a fix for this shortly

[kigster]

Fixed in version 3.2.0, by #38 and #35