Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import of filenames with special characters fails #22

Open
fschaeffler opened this issue May 27, 2021 · 2 comments
Open

import of filenames with special characters fails #22

fschaeffler opened this issue May 27, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@fschaeffler
Copy link

In some of our Mercurial repositories, we have filenames with special characters. This brings some issues as they're not properly handled. For the test case here, I used the German ö (o with two dots at the top).

Note: ö has the octal value of 366 in ISO/IEC 8859.

Mercurial Repo:

  • src/file.txt
  • src/file-with-special-character-ö.txt

Created Git Repo:

  • src/file.txt
  • 'src/file-with-special-character-'$'\366''.txt'

Import Verification:

[...]
Only in repo-mercurial/src/file-with-special-character-ö.txt
Only in repo-git/src/file-with-special-character-�.txt
@fschaeffler
Copy link
Author

What I found out so far is that the original Mercurial repository files were created not with utf8 but with latin1.

@kilork
Copy link
Owner

kilork commented Jun 2, 2021

I have special test repository which uses cp1251 filename encoding, it was created in Windows. Actually, the file path handling logic is one of most untransparent in this project, I would be glad for any suggestions on how to improve this.

To fix this error we need to have minimal reproduction example, something with maybe just one commit which should be enough.

@kilork kilork added the bug Something isn't working label Jun 2, 2021
@kilork kilork added this to the 1.4 milestone Aug 25, 2021
@kilork kilork removed this from the 1.4 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants