Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Non-SvelteKit style access to environment variables #59

Open
4 tasks done
colinbate opened this issue Dec 10, 2024 · 1 comment
Open
4 tasks done

Bug: Non-SvelteKit style access to environment variables #59

colinbate opened this issue Dec 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@colinbate
Copy link

Prerequisites

Describe the issue

As part of issue #36 a new environment variable was added to the lib/hooks/sessionHooks.ts file. That change attempts to use process.env, which isn't available in all environments that SvelteKit may be running in.

This should be changed to the SvelteKit mechanism used elsewhere in the SDK:

import { env } from "$env/dynamic/private";

// ...
{ domain: env.KINDE_COOKIE_DOMAIN, /* ... */ }

I can make a PR if that is preferred.

Library URL

https://github.com/kinde-oss/kinde-sveltekit-sdk

Library version

2.1.0

Operating system(s)

macOS

Operating system version(s)

Sequoia 15.1

Further environment details

Cloudflare Pages

Reproducible test case URL

No response

Additional information

No response

@colinbate colinbate added the bug Something isn't working label Dec 10, 2024
@DanielRivers
Copy link
Contributor

@colinbate you wanted to create a PR that would be great and I will get that reviewed and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants