From b86c9935f183dcd6a34d38d3020e779f58f7217c Mon Sep 17 00:00:00 2001 From: Nikita Korobeinikov Date: Tue, 28 Mar 2023 20:56:03 +0400 Subject: [PATCH 1/2] update gem and pod dependencies --- Example/Podfile.lock | 4 ++-- Gemfile | 2 +- Sources/Podfile.lock | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Example/Podfile.lock b/Example/Podfile.lock index c5bd1cc4..b2aa5a91 100644 --- a/Example/Podfile.lock +++ b/Example/Podfile.lock @@ -21,11 +21,11 @@ EXTERNAL SOURCES: :path: "../" SPEC CHECKSUMS: - KinescopeSDK: 0e32c16a8005fc08901dac4ba2c0da820b6fe497 + KinescopeSDK: cf9a88913bab22ef14c732ece567993863b4ba00 Kingfisher: e71c6fac2aebb1262888cabc2cb13d313362a48f ReactiveDataDisplayManager: 0ff30e94f5c9785e4f366ca5e09bef00eb6a8ba8 SwiftProtobuf: 4e16842b83c6fda06b10fac50d73b3f1fce8ab7b PODFILE CHECKSUM: 16301e56b578a66ff683d6aae023c456365e17e9 -COCOAPODS: 1.10.1 +COCOAPODS: 1.10.2 diff --git a/Gemfile b/Gemfile index ffdd8e80..275c3525 100644 --- a/Gemfile +++ b/Gemfile @@ -7,7 +7,7 @@ git_source(:github) do |repo_name| "https://github.com/#{repo_name}.git" end if Gem::Version.new(Bundler::VERSION) < Gem::Version.new('2') -gem 'cocoapods', "1.7.3" +gem 'cocoapods', "1.10.1" gem 'danger' gem 'danger-the_coding_love' gem 'danger-swiftlint' diff --git a/Sources/Podfile.lock b/Sources/Podfile.lock index 697362a7..34bf19bb 100644 --- a/Sources/Podfile.lock +++ b/Sources/Podfile.lock @@ -5,7 +5,7 @@ DEPENDENCIES: - SwiftProtobuf (~> 1.0) SPEC REPOS: - https://github.com/cocoapods/specs.git: + https://github.com/CocoaPods/Specs.git: - SwiftProtobuf SPEC CHECKSUMS: @@ -13,4 +13,4 @@ SPEC CHECKSUMS: PODFILE CHECKSUM: c2dda49b4bff3b9bc41ca4197753ace3179f31af -COCOAPODS: 1.7.3 +COCOAPODS: 1.10.1 From ad0d6d0fd7d2b591ad2a07265bcb403fb3cb5cfe Mon Sep 17 00:00:00 2001 From: Nikita Korobeinikov Date: Tue, 28 Mar 2023 21:00:49 +0400 Subject: [PATCH 2/2] add safe unwrap of optional url from KinescopeVideoAsset --- .../Player/KinescopeVideoQuality+AVPlayerItem.swift | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Sources/KinescopeSDK/Player/KinescopeVideoQuality+AVPlayerItem.swift b/Sources/KinescopeSDK/Player/KinescopeVideoQuality+AVPlayerItem.swift index 8e1dde2f..2022d339 100644 --- a/Sources/KinescopeSDK/Player/KinescopeVideoQuality+AVPlayerItem.swift +++ b/Sources/KinescopeSDK/Player/KinescopeVideoQuality+AVPlayerItem.swift @@ -38,7 +38,8 @@ fileprivate extension KinescopeVideoQuality { } func makeExactItem(from asset: KinescopeVideoAsset) -> AVPlayerItem? { - guard let url = URL(string: asset.url) else { + guard let urlString = asset.url, + let url = URL(string: urlString) else { return nil } @@ -47,8 +48,8 @@ fileprivate extension KinescopeVideoQuality { func makeExactItem(from asset: KinescopeVideoAsset, subtitles: KinescopeVideoSubtitle) -> AVPlayerItem? { - guard - let url = URL(string: asset.url) + guard let urlString = asset.url, + let url = URL(string: urlString) else { return nil }