Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: logging to file resets lazy_load_blob #108

Open
nick1udwig opened this issue Nov 13, 2024 · 1 comment
Open

bug: logging to file resets lazy_load_blob #108

nick1udwig opened this issue Nov 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@nick1udwig
Copy link
Collaborator

Describe the bug
https://discord.com/channels/1186394868336038080/1306250401451999253

If you receive an HTTP request and log it (e.g. info!(); sending to println!() is fine) before reading the body with get_blob(), logging it to file will have replaced the blob. This happens because we Append to the log file, receiving a Result back from vfs, and hence, replacing our lazy_load_blob with None.

Code trace:

  1. The file logger .append() call
  2. What that .append() call does under the hood: Append and handle Response from vfs
  3. lazy_load_blobs are thrown out when a new message is received

Expected behavior
Logging should not alter lazy_load_blob.

@nick1udwig nick1udwig added the bug Something isn't working label Nov 13, 2024
@nick1udwig
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant