-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to set the dashboard to full-screen #19
Comments
I would like to get my hands on it but Im having trouble with setting the development environment. Would the following be the best approach to it?
Is this currently the only way? Thanks |
When the feature requires tweaking generated files that's the way. |
I've completely failed at step 2 mainly because I have no idea about elixir. That has to be a general problem with folks that wants to contribute but can't. I guess it can easily be solved by adding richer documentation on how to setup a test project for people that don't want to mess with the backend side of the architecture. From a higher level, one would also see that this whole procedure kinda has problems. It requires manual work (merging changes back by hand) and there is no way of automatically testing the generated app. You can test what you generate but not what the generated app does. Last, you can't update previously generated apps at newer versions. My final suggestion would be to rethink of including the generated app directly in the repo and having consumers cloning it and running it, much like a boilerplate. Of course, you may have some great arguments on why you chose this kind of architecture. Hope that I helped a bit! :) |
@kbariotis Developer documentation is on the way (see: #88), you also welcome to comment there any additional info you feel worth adding. Concerning your thoughts on the current JavaScript development / upgrading workflow, your main worries have been discussed on #72 and #18. When the issues above are resolved, one will be able to upgrade both the core JavaScript library and the widgets without having to manually apply diffs. Fyi there are some smoke tests to assert that the generated dashboard backend works (see: https://github.com/kittoframework/kitto/blob/v0.4.0/test/mix/tasks/kitto.new_test.exs#L63) There no tests yet for the JavaScript part of the codebase (yet) though. |
great thanks for the info @zorbash. I will take a look at these issues and see how I can help. |
I'm thinking of a button like:
which is visible only when the mouse is not idle and when clicked sets the dashboard to full-screen.
The text was updated successfully, but these errors were encountered: