Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHACEMENT: warn about potential patch apply errors when package version requested don't match recipe #3088

Open
Fak3 opened this issue Dec 10, 2024 · 0 comments
Labels
need-analysis Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix recipe

Comments

@Fak3
Copy link
Contributor

Fak3 commented Dec 10, 2024

User can specify package version with --requirements option:
p4a apk --requirements=python3,pillow==7.1
Then p4a will download specified version instead of the one defined in the Pillow recipe. This recipe has patches to apply, and p4a will fail trying to do so because patch almost always strictly requires the exact input files of the particular package version - the package version which is specified in the recipe itself:

    self.handle_command_exit_code(exit_code)
  File "/home/u1/.local/share/pipx/venvs/python-for-android/lib64/python3.11/site-packages/sh.py", line 821, in handle_command_exit_code
    raise exc
sh.ErrorReturnCode_1:

  RAN: /usr/bin/patch -t -d /home/u1/.local/share/python-for-android/build/other_builds/Pillow/armeabi-v7a__ndk_target_24/Pillow -p1 -i /home/u1/.local/share/pipx/venvs/python-for-android/lib/python3.11/site-packages/pythonforandroid/recipes/Pillow/setup.py.patch

  STDOUT:
patching file setup.py
Hunk #1 FAILED at 39.
Hunk #2 succeeded at 156 with fuzz 1 (offset 6 lines).
Hunk #3 FAILED at 461.
Hunk #4 succeeded at 400 with fuzz 2 (offset -96 lines).
Hunk #5 FAILED at 507.
Hunk #6 succeeded at 500 (offset -107 lines).
3 out of 6 hunks FAILED -- saving rejects to file setup.py.rej

Suggestion: warn user clearly that the package version he requested does not match the recipe version, and the patch is likely to fail.

@kuzeyron kuzeyron added need-analysis recipe Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-analysis Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix recipe
Projects
None yet
Development

No branches or pull requests

2 participants