-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kiwisolver recipe fatal error: 'Python.h' file not found #3118
Conversation
Thanks, I guess a git pull does the job too, I can always squash/rebase upon merging. |
Sorry, I don't know why it doesn't work on MacOS, it also fails on kiwisolver, maybe something to do with the compiler? |
Yeah I haven't dug too much into it, but I tried to build it from develop and on macos-13 (not 14) and it's also not building, so I'll assume this isn't a regression from your PR. I'm good with merging, thanks again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks you all for looking this up
env["CFLAGS"] = flags | ||
env["CPPFLAGS"] = flags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mriscoc I'm seeing this late, but why didn't we append the flags rather than overriding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, that might be the reason macos runner might be failing. (Btw I am to blame for this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the recipe wasn't building anyway, so overall situation is better than the previous state.
From #3115: Fixes the problem with the KiwiSolver recipe in the current develop branch of pythonforandroid.
Error to fix:
buildozer.spec:
Minimal test: