Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use identifiers and labels for Tabs and SegmentedSwitch buttons #584

Open
PavelHolec opened this issue Jun 1, 2023 · 0 comments
Open

Use identifiers and labels for Tabs and SegmentedSwitch buttons #584

PavelHolec opened this issue Jun 1, 2023 · 0 comments
Labels
accessibility Issues supporting accessibility features

Comments

@PavelHolec
Copy link
Collaborator

PavelHolec commented Jun 1, 2023

To enable proper accessibility of content inside these components, we should:

Solution 1 (simpler, not accurate):

  • mark content with isButton trait
  • hide button layer from accessibility
  • Blocker: The trait isSelected needs to be propagated to correct content

Solution 2 (complicated, accurate):

  • add preference keys for content that include accessibilityIdentifier and textLabel
  • use these keys when creating buttons to assign them IDs and labels
  • hide content layer from accessibility
  • active button keeps isSelected trait
@PavelHolec PavelHolec added the accessibility Issues supporting accessibility features label Jun 1, 2023
@PavelHolec PavelHolec changed the title Use identifiers and labels for Tabs and SegmentedSwitch buttons Use identifiers and labels for Tabs and SegmentedSwitch buttons Jun 1, 2023
@PavelHolec PavelHolec added this to the 2023Q3 milestone Jun 19, 2023
@PavelHolec PavelHolec modified the milestones: 2023Q3, 2023Q4 Oct 16, 2023
@PavelHolec PavelHolec modified the milestones: 2023Q4, 2024Q1 Jan 5, 2024
@PavelHolec PavelHolec removed this from the 2024Q1 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues supporting accessibility features
Projects
None yet
Development

No branches or pull requests

1 participant