Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

[SW-295] Remove default static secret key from the base settings #264

Open
fuomag9 opened this issue Dec 17, 2019 · 1 comment
Open

[SW-295] Remove default static secret key from the base settings #264

fuomag9 opened this issue Dec 17, 2019 · 1 comment
Assignees

Comments

@fuomag9
Copy link

fuomag9 commented Dec 17, 2019

The-zoo is vulnerable to a cryptography issue since the Django's SECRET_KEY in settings.py variable will fallback to mucho secretto if no SECRET_KEY environment variable is provided when deploying the webserver.

Steps To Reproduce:

  • Deploy the-zoo without providing a SECRET_KEY environment variable
  • Django's SECRET_KEY will default to mucho secretto as per line 79 in settings.py

Vulnerable line: SECRET_KEY = env("SECRET_KEY", default="mucho secretto")

Impact:

Running Django with a known SECRET_KEY defeats many of Django’s security protections, and can lead to privilege escalation and remote code execution vulnerabilities.

Remediation:

Preventing the start or generating a random key for every run might be a better practice

@aexvir
Copy link
Member

aexvir commented Dec 17, 2019

👋 Hi @fuomag9 , thanks for raising awareness on this issue

I agree that specifying a default secret key might end up causing issues to other people wanting to deploy this project, I believe it was set up mainly to facilitate local development, but we can definitely set it up in the docker-compose.yml file instead of the settings.py file to avoid this.

@aexvir aexvir self-assigned this Dec 17, 2019
@aexvir aexvir changed the title The-zoo is vulnerable to a cryptography issue since the Django's SECRET_KEY in settings.py variable will fallback to mucho secretto if no SECRET_KEY environment variable is provided when deploying the webserver Remove default static secret key from the base settings Dec 18, 2019
@aexvir aexvir changed the title Remove default static secret key from the base settings [SW-295] Remove default static secret key from the base settings Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants