Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out "best" way to re-enable PostgresAppTestExtensionTest on macOS #80

Closed
sleberknight opened this issue Sep 2, 2020 · 1 comment · Fixed by #197
Closed

Figure out "best" way to re-enable PostgresAppTestExtensionTest on macOS #80

sleberknight opened this issue Sep 2, 2020 · 1 comment · Fixed by #197
Labels
enhancement A request for change or improvement to an existing feature investigation Something that needs to be investigated before implementation can proceed
Milestone
0.16.0

Comments

@sleberknight
Copy link
Member

Fix build and/or provide instructions so that PostgresAppTestExtensionTest works on Mac OS both running via Maven and IntelliJ.

Solution seems to just be setting the LC_XXX environment vars:

export LC_CTYPE="en_US.UTF-8"
export LC_ALL="en_US.UTF-8"

Which presumably we can do in the Maven POM.

Related to this:
@sleberknight sleberknight added enhancement A request for change or improvement to an existing feature investigation Something that needs to be investigated before implementation can proceed labels Sep 2, 2020
@sleberknight sleberknight mentioned this issue Sep 2, 2020
Merged
@sleberknight
Copy link
Member Author

We should also apply the same EnabledIf to the PostgresLiquibaseTestExtensionTest

This was referenced Oct 23, 2020
Closed
Closed
sleberknight added a commit that referenced this issue Nov 3, 2020
@sleberknight
Enable PostgresLiquibaseTestExtensionTest only on Linux
25c2ee7 
This should be temporary. See issues #80 and #152

Fixes #151
@sleberknight sleberknight mentioned this issue Nov 3, 2020
Merged
sleberknight added a commit that referenced this issue Nov 3, 2020
@sleberknight
Enable PostgresLiquibaseTestExtensionTest only on Linux (#154)
8cdc24d 
This should be temporary. See issues #80 and #152

Fixes #151
@sleberknight sleberknight added this to the 0.16.0 milestone Feb 28, 2021
sleberknight added a commit that referenced this issue Feb 28, 2021
@sleberknight
Re-enable tests that use embedded Postgres
3b6b9f7 
Since we originally implemented these and had problems running the
tests on macOS, things seem to have gotten fixed. So this commit simply
removes the EnabledOnOs annotation that restricted to Linux. I don't
really care about Windows, and doubt anyone is using this there anyway.

See:

zonkyio/embedded-postgres#32
zonkyio/embedded-postgres#40

Also see:

zonkyio/embedded-postgres#11
zonkyio/embedded-postgres#11 (comment)

for the original solution regarding the LC_CTYPE and LC_ALL environment
variables.

Closes #80
Closes #152
@sleberknight sleberknight mentioned this issue Feb 28, 2021
Merged
sleberknight added a commit that referenced this issue Feb 28, 2021
@sleberknight
Re-enable tests that use embedded Postgres (#197)
127c46f 
Since we originally implemented these and had problems running the
tests on macOS, things seem to have gotten fixed. So this commit simply
removes the EnabledOnOs annotation that restricted to Linux. I don't
really care about Windows, and doubt anyone is using this there anyway.

See:

zonkyio/embedded-postgres#32
zonkyio/embedded-postgres#40

Also see:

zonkyio/embedded-postgres#11
zonkyio/embedded-postgres#11 (comment)

for the original solution regarding the LC_CTYPE and LC_ALL environment
variables.

Closes #80
Closes #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A request for change or improvement to an existing feature investigation Something that needs to be investigated before implementation can proceed
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Re-enable tests that use embedded Postgres kiwiproject/kiwi-test
1 participant
@sleberknight