Deleting ZIM file should stop playing pip video

[kelson42]

If I play a video in pip and delete the source ZIM from the library, then the video continues. It should be stopped.

[kelson42]

@BPerlakiH Is that doable?

[BPerlakiH]

@kelson42 I am looking into it. It seems we need to close the tabs related to the ZIM content, which eg. in case of macOS is not happening at the moment.

[kelson42]

@BPerlakiH This was impacting my iPad

[BPerlakiH]

Thank you, I did found a way to handle this on the iPad. I do see related issues on the iPhone and macOS which behave differently, so I will investigate those further.

[kelson42]

I obviously don't understand all the details but deleting/unlinking a ZIM file should delete all related items: bookmarks, library entries, tabs... etc.

I would add that should be better be implemented via constraints (for example a tab can not exist if the related library entry does not exist) than imperatively (when I delete a tab, I should check if there is a pip running). Is that doable?

[BPerlakiH]

I obviously don't understand all the details but deleting/unlinking a ZIM file should delete all related items: bookmarks, library entries, tabs... etc.

I would add that should be better be implemented via constraints (for example a tab can not exist if the related library entry does not exist) than imperatively (when I delete a tab, I should check if there is a pip running). Is that doable?

I will have a look. The things that are reflected in the local DB eg: tabs and bookmarks are more closer to those constraints, which you described, whereas some other parts (BrowserViewModel, WKWebView, Picture in Picture) are more loosely coupled. Some of these are returning pain-points to be honest, so I will think about them, how to change those to be better for the future.