Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a Zimit-based article is opened in a separate tab, external links and PDFs are blocked #1202

Open
Jaifroid opened this issue Jan 24, 2024 · 5 comments
Assignees
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix security zimit Code relating to the support of Zimit-style archives
Milestone

Comments

@Jaifroid
Copy link
Member

See kiwix/kiwix-js-pwa#540 for full explanation. Let's wait to see if zimit2 is affected, because this is an edge case in zimit classic caused by sandboxing of the replay_iframe.

@Jaifroid Jaifroid added security bug-non-critical For bugs that it would be nice to fix rather than critical to fix zimit Code relating to the support of Zimit-style archives labels Jan 24, 2024
@Jaifroid Jaifroid added this to the v4.1 milestone Jan 24, 2024
@Jaifroid Jaifroid modified the milestones: v4.2, v4.3 Jul 14, 2024
@THEBOSS0369
Copy link
Collaborator

Hey @Jaifroid ! I can work on this issue if it still exists. But first can you tell me which ZIM i can used to recreate this issue.
Also in which repo this issue has to be solved in kiwix-js or in kiwix-js-pwa or in both?

@asmit27rai
Copy link

@Jaifroid I Want To Work On This Issue.

@Jaifroid
Copy link
Member Author

@THEBOSS0369 Asked first on this. @THEBOSS0369 Are you still interested in this issue (to work on in January)?

@THEBOSS0369
Copy link
Collaborator

@THEBOSS0369 Asked first on this. @THEBOSS0369 Are you still interested in this issue (to work on in January)?

@Jaifroid Yes sir i'm still very much interested in working on this issue.

@THEBOSS0369
Copy link
Collaborator

@Jaifroid Sir can you tell me whether this issue is still present or not i tried to recreate this issue but wasn't able to find it. Please see the screen recorder below
https://github.com/user-attachments/assets/46e079cb-9b15-499a-9968-8279845d3b99

If the issue is still present please let me know which zim i can use to recreate this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix security zimit Code relating to the support of Zimit-style archives
Projects
None yet
Development

No branches or pull requests

3 participants