Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make download button at library.kiwix.org more conspicuous #1040

Open
Popolechien opened this issue Jan 2, 2024 · 14 comments
Open

Make download button at library.kiwix.org more conspicuous #1040

Popolechien opened this issue Jan 2, 2024 · 14 comments

Comments

@Popolechien
Copy link
Member

We've received repeat comments from users that they at first can't figure out where the download function is. The download button as it stands could be a bit more conspicuous, including an actual download icon.

The file size that is also included in the download text could be moved somewhere else on the card so as to make space for the download icon.

@Jaifroid
Copy link
Member

Jaifroid commented Jan 4, 2024

I think just giving the "Download" button more height (it's very narrow), and maybe styling it to look more button-like, ought to do the trick.

An alternative would be to make a click anywhere on the tile open the download menu, and have "Browse this ZIM" as one item in that menu.

@kelson42
Copy link
Collaborator

The size could be given if the layer proposing the multiple methids of download. We should then be able to propose a proper download button at the bottom of the tile.

@kelson42 kelson42 modified the milestones: 13.1.0, 13.2.0 Jan 30, 2024
@kelson42
Copy link
Collaborator

@Popolechien At this stage we need a proposal in HTML. Nothin fancy:

  • a button a the bottom of the tile
  • Add the size in download overlay

@juuz0
Copy link
Collaborator

juuz0 commented May 12, 2024

what about this? :>

Screencast.from.2024-05-12.18-28-41.webm

@kelson42
Copy link
Collaborator

@juuz0 Thank you for helping moving forward but:

  • Make it full width, below the tags and language (it should be more visible and if we have many tags, we will have problem)
  • Put the size in the overlay

@juuz0
Copy link
Collaborator

juuz0 commented May 13, 2024

@kelson42
I kept the size in Download button (and also added in the overlay), but can remove if you want - I felt it would be wise to not lose information

Screencast.from.2024-05-13.23-43-51.webm

@kelson42
Copy link
Collaborator

@juuz0 Not sire about all details, but this is more or less what I had in mind. @Popolechien ?

@Popolechien
Copy link
Member Author

LGTM. Does this means that the rest of the card is clickable to display the zim content? If yes then maybe increase the button's height a teeny weeny bit.

@kelson42
Copy link
Collaborator

LGTM. Does this means that the rest of the card is clickable to display the zim content? If yes then maybe increase the button's height a teeny weeny bit.

@Popolechien Yes, thanks for the feedback.
@juuz0 Could you please share here your HTML mockup, so I can try to tweak it a bit?

@D3V-D
Copy link

D3V-D commented May 14, 2024

I have an additional suggestion, which I can make a mock-up for, but basically I feel a lot of users would want to preview a ZIM first, then download. Thus, it makes sense to have a download button in the ZIM preview page. I'll send a demo here soon

@kelson42
Copy link
Collaborator

I have an additional suggestion, which I can make a mock-up for, but basically I feel a lot of users would want to preview a ZIM first, then download. Thus, it makes sense to have a download button in the ZIM preview page. I'll send a demo here soon

I 100% agree with this but this should be handled in an other issue.

@D3V-D
Copy link

D3V-D commented May 14, 2024

Sure; should I go ahead and create it?

@juuz0
Copy link
Collaborator

juuz0 commented May 14, 2024

@juuz0 Could you please share here your HTML mockup, so I can try to tweak it a bit?

@kelson42 its in the downloadBtn branch, you can fetch and tweak.
I increased the padding a bit so it looks like this currently:
image

@kelson42
Copy link
Collaborator

@juuz0 Sorry stiil have taken the time, but will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants