Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kiwix::getDataDirectory() should be moved to kiwix/kiwix-desktop repository #1087

Open
kelson42 opened this issue May 19, 2024 · 0 comments
Open

kiwix::getDataDirectory() should be moved to kiwix/kiwix-desktop repository #1087

kelson42 opened this issue May 19, 2024 · 0 comments
Assignees
@veloman-yunkan
Labels
question task
Milestone
13.3.0

Comments

@kelson42
Copy link
Collaborator

kelson42 commented May 19, 2024 •
edited
Loading

Reasons are that kiwix::getDataDirectory():

  • Is only used by Kiwix Desktop
  • Is anyway very specific whatever the version of Kiwix (OS)
  • Should be decided outside the libkiwix (not the duty of libkiwix)
  • Only used by the aria2c method and should be given there as function parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veloman-yunkan veloman-yunkan

Labels
question task
Projects
Portable Kiwix
Status: TODO
Milestone
13.3.0
Development

No branches or pull requests
2 participants
@kelson42 @veloman-yunkan