-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multizim (suggestions) does not work at all #479
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I tried to recreate this bug for a single zim file. In this case, the error occurs because of an empty |
@maneeshpm Sounds good but we need to think about the scalability as well. How can we secure a proper response, on time, with 2000 ZIM files? |
This reminds me a little bit of a meta search engine. The meta search engine queries several search engines and doesn't know, when this will finish. In past some meta search engines provided an interface with a user selectable timeout and a list where search engines could be choosen grouped by categories or languages. If you think of a timeout between http server and browser, then the server could send a line with a space once in a while, until the search is finished. If the search result page gets an anchor in the URL, the empty line could get ignored by placing the anchor at the begin of the results. A caching could be helpful, when several people do the same search, e.g. a school class searches during a lesson. For single user this could be helpful, if the first search gets a short timeout and when the search is repeated the caches serves the full response. Maybe a line with the timeout avoiding spaces could be placed at the end of a fast search and when the server finishes the search the user gets a link with "Reload to see all results". When the first browser request is made to the server, the server could response with a "dynamic" start page where the languages are selected, which the user activated in the browser eg. "DE(-ch), EN(-us)". The user could then enter the search phrase and modify the languages. |
According to this thread on Xapian, Xapian can handle search over multiple databases with a very small overhead compared to single database search. For that, all the databases should be added simultaneously using the PS: I guess this ticket openzim/libzim#418 is well written and captures the issue very well. |
What do you mean exactly here? the IO overhead? Or simply what is reported in openzim/libzim#418? |
I meant the net cost of (reading a zim + getting the index + adding it to |
I think this issue is more suited for kiwix-lib instead of kiwix-tools since the bug is there.
I think till the issue of scaling up is sorted, we should hide this feature from the main page as it hurts the user experience for a high number of zims. |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
@kelson42 we can say as a fact that once a Xapian database is ready, search on it is quick(even on huge Xapian DB) and that is something we cannot improve on our side. Now our main concern is how to make the DB ready first time and how to keep it ready for further searches. Answer to how to keep it ready is caching, which we have already started looking into in #509 Answering how to make it ready first time quickly is a bit more complicated. Currently in libkiwix side, we make a Now what to do till the |
The topic of the cold start is already touched in openzim/libzim#418. I would keep this topic outside this ticket. That said I still believe that if kiwix-serve has 2000 zim files open, then a multizim search won't give an answer in a reasonable time and memory consumption. This is IMO mostly what this ticket is about. |
Here is how I would propose to proceed. First of all this is a quite lartge ticket, so I would first propose to split it in following tasks:
@maneeshpm @mgautierfr Do you agree? Have you comments? |
Depends on #509 |
@maneeshpm Would you mine to tackle the multizim problem until we fix the last details of #509? Maybe you have a feedback obout my last comment? |
Fulltext multizim search is fixed with #731. The multizim suggestion work is left to do. |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
I guess this is ticket fot openzim/linbzim meanwhile. We should fix openzim/libzim#734 forst IMO. |
If I search for suggestion in the welcome page, nothing is printed.
I would like to see the results and it would be great to have the logo of the ZIM beside to see in which content the content is available.
See kiwix/kiwix-tools#385 for the fulltext search multizim lack of scalability
The text was updated successfully, but these errors were encountered: