Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the viewer handle itself the external link warning. #960

Open
mgautierfr opened this issue Jun 21, 2023 · 0 comments
Open

Make the viewer handle itself the external link warning. #960

mgautierfr opened this issue Jun 21, 2023 · 0 comments
Labels
enhancement kiwix-serve

Comments

@mgautierfr
Copy link
Member

For now, we are blocking navigation to external link by replacing the link to the catch-external endpoint.

This was done this way when we didn't have a viewer and we was working mostly without js.

But now, the viewer itself could pop a warning when use click on a external link instead of redirecting to the catch-external endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement kiwix-serve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgautierfr @kelson42