Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default ZIM icon (if no icon in the ZIM) is not displayed in tab bar #989

Open
kelson42 opened this issue Aug 4, 2023 · 3 comments
Open

Default ZIM icon (if no icon in the ZIM) is not displayed in tab bar #989

kelson42 opened this issue Aug 4, 2023 · 3 comments
Assignees
@kelson42
Labels
bug enhancement question
Milestone
13.3.0

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Aug 4, 2023

image

It should display the default icon like in the library

Tested with https://library.kiwix.org/?lang=fr&q=ubuntu#lang=fra&q=ubuntu
@kelson42 kelson42 added the bug label Aug 4, 2023
@kelson42 kelson42 mentioned this issue Aug 4, 2023
Closed
@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 4, 2023

@mgautierfr I really wonder if we should not build something at a low level in the libkiwix to provide the placeholder icon... otherwise we might have dozens of such tickets all over the reader landscape.

@kelson42 kelson42 transferred this issue from kiwix/kiwix-desktop Aug 12, 2023
@kelson42 kelson42 added this to the 13.1.0 milestone Aug 12, 2023
@kelson42 kelson42 mentioned this issue Sep 30, 2023
Closed
@kelson42
Copy link
Collaborator Author

@rgaudin @benoit74 I would like your feedback on this last comment... I'm still not 100% sure.

@kelson42 kelson42 self-assigned this May 11, 2024
@rgaudin
Copy link
Member

rgaudin commented May 11, 2024

Not a replacement of course but we have a lot of things in place to prevent openZIM from creating ZIM without icons now. This ticket's example is quite old

@kelson42 kelson42 modified the milestones: 13.2.0, 13.3.0 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelson42 kelson42

Labels
bug enhancement question
Projects
None yet
Milestone
13.3.0
Development

No branches or pull requests
2 participants
@rgaudin @kelson42