Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jakarta namespace migration #82

Open
reda-alaoui opened this issue Jan 23, 2023 · 4 comments · May be fixed by #83
Open

Jakarta namespace migration #82

reda-alaoui opened this issue Jan 23, 2023 · 4 comments · May be fixed by #83

Comments

@reda-alaoui
Copy link

Hello,

Would it be possible to move to the jakarta namespace by replacing javax.websocket:javax.websocket-api:1.1 with jakarta.websocket:jakarta.websocket-api:2.1.0 ?
@reda-alaoui reda-alaoui mentioned this issue Jan 23, 2023
Closed
@JAndrassy
Copy link

javax.websocket:javax.websocket-api is a dependency of the tyrus library. it is only redundant in the cdt:cdt-java-client pom

+--- com.github.kklisura.cdt:cdt-java-client:4.0.0
|    +--- javax.websocket:javax.websocket-api:1.1
|    +--- org.glassfish.tyrus:tyrus-container-grizzly-client:1.13.1
|    |    +--- org.glassfish.grizzly:grizzly-framework:2.3.25
|    |    +--- org.glassfish.grizzly:grizzly-http-server:2.3.25
|    |    |    \--- org.glassfish.grizzly:grizzly-http:2.3.25
|    |    |         \--- org.glassfish.grizzly:grizzly-framework:2.3.25
|    |    \--- org.glassfish.tyrus:tyrus-client:1.13.1
|    |         \--- org.glassfish.tyrus:tyrus-core:1.13.1
|    |              \--- org.glassfish.tyrus:tyrus-spi:1.13.1
|    |                   \--- javax.websocket:javax.websocket-api:1.1
|    +--- org.javassist:javassist:3.24.1-GA
|    +--- org.slf4j:slf4j-api:1.7.25
|    +--- com.fasterxml.jackson.core:jackson-core:2.11.3
|    +--- com.fasterxml.jackson.core:jackson-annotations:2.11.3
|    \--- com.fasterxml.jackson.core:jackson-databind:2.11.3
|         +--- com.fasterxml.jackson.core:jackson-annotations:2.11.3
|         \--- com.fasterxml.jackson.core:jackson-core:2.11.3

@reda-alaoui reda-alaoui linked a pull request Jan 23, 2023 that will close this issue
Open
@reda-alaoui
Copy link
Author

@JAndrassy Good to know. I created #83 in the time between.

@reda-alaoui
Copy link
Author

reda-alaoui commented Jan 23, 2023 •
edited
Loading

javax.websocket:javax.websocket-api is a dependency of the tyrus library. it is only redundant in the cdt:cdt-java-client pom

Are you saying that a cdt:cdt-java-client consumer can exclude javax.websocket:javax.websocket-api without issue?

@JAndrassy
Copy link

javax.websocket:javax.websocket-api is a dependency of the tyrus library. it is only redundant in the cdt:cdt-java-client pom

Are you saying that a cdt:cdt-java-client consumer can exclude javax.websocket:javax.websocket-api without issue?

yes. but the javax.websocket:javax.websocket-api:1.1 will still be included in compile and runtime classpath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jakarta namespace migration Cosium/chrome-devtools-java-client
2 participants
@reda-alaoui @JAndrassy