Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RLP Library to new Cairo #208

Closed
5 tasks done
Tracked by #207
Eikix opened this issue Aug 28, 2023 · 6 comments
Closed
5 tasks done
Tracked by #207

Migrate RLP Library to new Cairo #208

Eikix opened this issue Aug 28, 2023 · 6 comments
Assignees

Comments

@Eikix
Copy link
Member

Eikix commented Aug 28, 2023

In Kakarot, the EOA smart account uses RLP encoding

Tasks

@Eikix Eikix added this to the Kakarot Cairo Migration milestone Aug 29, 2023
@danilowhk
Copy link
Contributor

Can take this issue

@Eikix
Copy link
Member Author

Eikix commented Aug 30, 2023

I think @LucasLvy started but won't have time to finish.
Basically his findings is that RLP from Herodotus is good enough, next task would be to:

  • Import RLP from kkrt-labs/cairo-lib fork into kakarot-ssj
  • Migrate RLP tests from Kakarot cairo 0
  • Make sure they pass using the RLP from cairo-lib. If it doesn't pass, then alert team and create new issues to either -> fix cairo-lib RLP package, or migrate our own.

@Eikix
Copy link
Member Author

Eikix commented Aug 30, 2023

Can take this issue

Assigned you!

@Eikix
Copy link
Member Author

Eikix commented Sep 8, 2023

Important update: we are gathering some bugs in the Kakarot v0 codebase, we need to make sure each issue and each PR in Kakarot-ssj is aware of the lists of known bugs. Look at this tracking issue everytime you take an issue and check your issue isn't targeted by a known bug. Will add this reminder in many places to make sure we keep track of known bugs.

@Eikix
Copy link
Member Author

Eikix commented Oct 6, 2023

@Quentash this is the issue you're doing now and opened a PR for #405

@Quentash
Copy link
Contributor

Quentash commented Oct 6, 2023

Alright !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants