Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move database from json to sql #60

Closed
CaedenPH opened this issue Aug 2, 2022 · 1 comment
Closed

Move database from json to sql #60

CaedenPH opened this issue Aug 2, 2022 · 1 comment

Comments

@CaedenPH
Copy link

CaedenPH commented Aug 2, 2022

As the title says, move the example from json to an sql-like database, such as sqlite. This imposes the challenge of the user having to set up a database, which is good experience for the user and teaches them not to use storage types such as json.

#59

@kkrypt0nn
Copy link
Owner

That is in my Todo list, yeah, but I believe they way you've implemented in the PR was a "as quickly as possible" made feature for it and doesn't contain what it should. For me the PR is a poor implementation of sqlite.

My plans were to move to sqlite once I move it back to discord.py 2.0 (stable, not beta). Hence I don't plan on implementing before doing so.
If discord.py doesn't make a stable release in the coming month, I will move in the coming month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants