Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro disappears when typing in search query #4

Open
ghost opened this issue Sep 7, 2016 · 4 comments
Open

Intro disappears when typing in search query #4

ghost opened this issue Sep 7, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Sep 7, 2016

I don't think the intro should disappear when you're typing in search queries. For instance, I could want to type in one of the example queries, with or without slight changes, so I want to be able to see them as I type. But the main thing is that when it disappears it looks like the results are going to come up, but then they don't and I've waited for nothing.

I saw your comment about UX and decided to start here. I'm developing my own application and I totally sympathise with not wanting to make something public until the UX is right. But I do believe it's better to have users feeding back on UX, rather than trying to imagine use cases. It's hard to complain if it's functionality you can't get anywhere else. So I hope this helps!

@klaftertief
Copy link
Owner

The intro now stays, you might need to refresh your browser to get the new script.
And thanks for the feedback, I'm happy to see that people are using it, even though I would not call it finished.

@prikhi
Copy link
Contributor

prikhi commented Sep 8, 2016

After my changes, you have to submit an empty search to get the intro text back. I was thinking I could add a Message triggered by clicking the logo that would clear the search & show the intro text again. @klaftertief let me know if you'd accept that or have any feedback.

I'm happy to see that people are using it, even though I would not call it finished.

Coming from Haskell and Hoogle, it's super useful way to discover common functions with different names(like const == always) and to figure out what packages some functions are in(like Maybe a -> Bool).

And due to the nature of the app, all your users are Elm users that can potentially contribute back to the project.

If you have any other ideas for fleshing out the app to where you'd consider it "finished", feel free to make some issues & I'll see if I can tackle them.

@klaftertief
Copy link
Owner

Yep, I noticed the behaviour to get back the intro text. I have to think about this page (or more general some Help UI) as there searching by name or type are not the only available searches. For now it's ok.

I'll be talking about elm-search at the next Elm Remote Meetup on September 21 and I'll set up a proper readme and issues until then. This is the other main thing to do for a proper announcement.

I'm sick a the moment, so you sadly have to wait a little for a more detailed feedback.

@prikhi
Copy link
Contributor

prikhi commented Sep 9, 2016

All good, please take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants